Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #8959 (closed)

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

Bug: Batch Annotate Exceptions

Reported by: wmoore Owned by: wmoore
Priority: major Milestone: OMERO-4.4
Component: Web Version: n.a.
Keywords: n.a. Cc: atarkowska
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: 2012-06-05 (16)

Description

Currently we don't check whether a Tag etc exists on an Object before we try to add it.

container.py 678

        try:
            # will fail if any of the links already exist
            saved_links = self.conn.getUpdateService().saveAndReturnArray(new_links, self.conn.CONFIG['SERVICE_OPTS'])
        except omero.ValidationException, x:

Although this fails silently for the user, it creates lots of Exceptions in the logs.

Would be nicer to check first whether links exist.

Change History (2)

comment:1 Changed 12 years ago by wmoore

  • Resolution set to fixed
  • Status changed from new to closed

Check whether a link exists before we try to create one: https://github.com/will-moore/openmicroscopy/commit/32eaa43f8beb76cb82ee13ea2e01f6e88d2ad513

Closing...

comment:2 Changed 12 years ago by Will Moore <will@…>

(In [32eaa43f8beb76cb82ee13ea2e01f6e88d2ad513/ome.git] on branch develop) Batch Annotate check for existing links. See #8959

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.75593 sec.)

We're Hiring!