Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #9063 (closed)

Opened 7 years ago

Closed 7 years ago

Bug: server lockup on "Already logged"

Reported by: jamoore Owned by: jamoore
Priority: critical Milestone: OMERO-4.4
Component: Services Version: n.a.
Keywords: n.a. Cc:
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2012-06-19 (17)

Description

Some service call is poisoning threads so that following calls are failing such as:

ame as name31_0_, this_.version as version31_0_ from experimentergroup this_ where this_.name=?
2012-06-04 16:50:39,317 WARN  [ome.services.sessions.state.SessionCache] (2-thread-2) 1error(s) on reload of 9e2c9943-8594-4285-9fc5-7c942a730308
java.lang.IllegalStateException: Already logged in. Use Executor.submit() and .get().
        at ome.services.util.Executor$Impl.execute(Executor.java:391)
        at ome.services.util.Executor$Impl.execute(Executor.java:350)
        at ome.services.sessions.SessionManagerImpl.reload(SessionManagerImpl.java:886)
        at ome.services.sessions.state.SessionCache.reload(SessionCache.java:628)
        at ome.services.sessions.SessionManagerImpl$5.call(SessionManagerImpl.java:696)        at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
        at java.util.concurrent.FutureTask.run(FutureTask.java:138)
        at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)        at java.lang.Thread.run(Thread.java:680)

Change History (2)

comment:1 Changed 7 years ago by jmoore

Output from $ grep -E "(Excp|WARN|ERROR|Already.logged)" var/log/Blitz-0.log | less:

2012-06-04 16:46:19,293 WARN  [           ome.services.graphs.GraphStep] (2-thread-5) Missing object 64 from Image/Instrument/Filter: root=7566
2012-06-04 16:46:54,639 WARN  [           ome.services.graphs.GraphStep] (2-thread-5) Missing object 156 from Image/Pixels/PixelsOriginalFileMap/OriginalFile/PixelsOriginalFileMap: root=7578
2012-06-04 16:47:34,763 INFO  [        ome.services.util.ServiceHandler] (2-thread-2)  Excp:    ome.services.blitz.impl.DeleteHandleI$Cancel: Cancelled by ConstraintViolation: fkimage_stagelabel_stagelabel
2012-06-04 16:49:29,486 WARN  [  ome.security.basic.BasicSecurityWiring] (2-thread-3) SessionTimeoutException on close:05e53720-65ca-40f7-972c-5a8dcf41e723
....
2-06-04 16:49:30,618 WARN  [  ome.security.basic.BasicSecurityWiring] (2-thread-3) SessionTimeoutException on close:43f5f1ee-5cc4-47ff-8d9f-70662d68b728
2012-06-04 16:49:30,637 WARN  [ome.services.sessions.state.SessionCache] (2-thread-5) 1error(s) on reload of 9e2c9943-8594-4285-9fc5-7c942a730308

My server was running in the debugger, which may be the ultimate cause, but it would be nice if the threads would correct themselves.

comment:2 Changed 7 years ago by jmoore

  • Remaining Time changed from 0.5 to 0
  • Resolution set to fixed
  • Status changed from new to closed

Fixed on sprint17-bugfixes.

commit 631898cb3f521e71b4790c65fa44c2cbb8925de8
Author: jmoore <josh@glencoesoftware.com>
Date:   Tue Jun 5 12:09:54 2012

    Cleanup current details on DoAll (Fix #9063)
    
    The use of the Push/Pop ContextMessage can leave
    a login active within CurrentDetails/PrincipalHolder.
    This corrupts the thread leading to fatal server errors.
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.81854 sec.)

© 2000-2014 University of Dundee & Open Microscopy Environment. Creative Commons Attribution 3.0 Unported License
OME source code is available under the GNU General public license or through commercial license from Glencoe Software

We're Hiring!