Property names and bean lookups should not be raw strings

[anonymous]

Configuration property names such as:

• hibernate.connection.url
• server.port
• renderService
• ...

should be available somewhere for static checking. This need not necessarily be a single interface, but rather in some sensible location.

There is a similar need for looking up services by name.

[jmoore]

This has happened partially with r704. (Login.java) but will need to be extended. Especially ServiceFactory.java suffers from this. A better technique would possibly be to consistently use interface names (Class.getName()) with a prefix:

• applicationContext.getBean("managed:"+IPojos.class.getName());
• applicationContext.getBean("internal:"+IPojos.class.getName());

This could then be internalized as:

• omeroContext.getManagedBean(IPojos.class.getName());
• omeroContext.getInternalBean(IPojos.class.getName());

[jmoore]

An idea coming from #183 for solving this involves moving all (or at least most) to similar classes (Login,Server,OMEDirectory,...) and using these within the configuration files (pseudo-Spring markup):

  <bean id="defaultProperties" class="...">
    <bean class="ome.config.Login"/>
    <bean class="ome.config.Server"/>
  </bean>

  <bean id="nonDefaultProperties" class="...">
    <bean class="ome.config.Login">
      <arg>${myName}</arg>
      <arg>${myPassword}</arg>
    </bean>
    <bean class="ome.config.Server"/>
  </bean>

Another option would be to move all config to the DB (except for that needed to access the DB). 

[jmoore]

Scheduling for the next milestone because of issues like that fixed in r750.

[jmoore]

r766 introduces several new fixes for this. In general, everyone should avoid looking up services (or really anything) directly from an OmeroContext and especially from the global, static OmeroContext.

Now several methods rather than taking strings take generic service interfaces if the form:

  public <T extends ServiceInterface> T lookup(Class<T> klass);

This is achieved by all service beans being named "<prefix>:<interface>" where prefix is currently "managed" or "internal". There are also two ServiceFactory subclasses (InternalServiceFactory and ManagedServiceFactory) which will only return the respective services.

[jmoore]

r831 as mentioned in #183 adds Server (like Login)

[jmoore]

Closing this. Particular values should iterface-ized, but we don't need to keep this ticket running until then.