Context Navigation

Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #9140 (closed)

Opened 7 years ago

Closed 7 years ago

Handle None in ordered collections

Reported by:	wmoore	Owned by:	wmoore
Priority:	major	Milestone:	OMERO-4.4.7
Component:	OmeroPy	Version:	n.a.
Keywords:	n.a.	Cc:	cneves, atarkowska, cxallan, jamoore
Resources:	n.a.	Referenced By:	n.a.
References:	n.a.	Remaining Time:	n.a.
Sprint:	n.a.

Description

See #7889.

Since any ordered collection can return None, we should identify all the places where this can happen and check if None.

This includes blitz gateway, web etc.

References

Change History (4)

comment:1 Changed 7 years ago by wmoore

To list all ordered collections in the model...

jrs-macbookpro-25107:OMERO will$ git grep 'ordered' components/model/resources/
components/model/resources/mappings/acquisition.ome.xml:                        <onemany name="pixels" type="ome.model.core.Pixels" inverse="image" ordered="true"/>
components/model/resources/mappings/acquisition.ome.xml:                        <manyone name="image" type="ome.model.core.Image" ordered="true"/>
components/model/resources/mappings/acquisition.ome.xml:                        <onemany name="channels" type="ome.model.core.Channel" inverse="pixels" ordered="true"/>
components/model/resources/mappings/acquisition.ome.xml:                        <manyone name="pixels" type="ome.model.core.Pixels" ordered="true"/>
components/model/resources/mappings/acquisition.ome.xml:                        <child name="excitationFilterLink" type="ome.model.acquisition.LightPathExcitationFilterLink" target="ome.model.acquisition.Filter" ordered="true"/>
components/model/resources/mappings/acquisition.ome.xml:                        <from_parent type="ome.model.acquisition.LightPath" ordered="true"/>
components/model/resources/mappings/display.ome.xml:                    <onemany name="waveRendering" type="ome.model.display.ChannelBinding" inverse="renderingDef" ordered="true"/>
components/model/resources/mappings/display.ome.xml:                    <zeromany name="spatialDomainEnhancement" type="ome.model.display.CodomainMapContext" inverse="renderingDef" ordered="true"/>
components/model/resources/mappings/display.ome.xml:                    <manyone name="renderingDef" type="ome.model.display.RenderingDef" ordered="true"/>
components/model/resources/mappings/display.ome.xml:                    <manyone name="renderingDef" type="ome.model.display.RenderingDef" ordered="true"/>
components/model/resources/mappings/meta.ome.xml:                       <parent name="groupExperimenterMap" ordered="true" type="ome.model.meta.GroupExperimenterMap" target="ome.model.meta.ExperimenterGroup"/>
components/model/resources/mappings/meta.ome.xml:                       <to_child type="ome.model.meta.Experimenter" ordered="true"/>
components/model/resources/mappings/roi.ome.xml:                        <onemany name="shapes" type="ome.model.roi.Shape" inverse="roi" ordered="true"/>
components/model/resources/mappings/roi.ome.xml:                        <manyone name="roi" type="ome.model.roi.Roi" inverse="shapes" ordered="true"/>
components/model/resources/mappings/screen.ome.xml:                     <zeromany name="wellSamples" type="ome.model.screen.WellSample" inverse="well" ordered="true"/>
components/model/resources/mappings/screen.ome.xml:                     <manyone name="well" type="ome.model.screen.Well" inverse="wellSamples" ordered="true"/>

Last edited 7 years ago by wmoore (previous) (diff)

comment:2 Changed 7 years ago by wmoore

Summarise previous comment:

Image -> Pixels (Only use pixels[0]. Ignore)
Pixels -> Channel (handled by rendering engine)
LightPath? - > Excitation Filter (Not Emission Filter!?)
Various Rendering display (ignore)
ExperimenterGroup? -> Experimenter
Roi -> Shape
Well -> Well-Sample

Last edited 7 years ago by wmoore (previous) (diff)

comment:3 Changed 7 years ago by wmoore

Null Shapes are being handled already, Experimenters and Excitation Filters handled by commits in https://github.com/will-moore/openmicroscopy/tree/ordered_nulls_9140.
Well Sample code is a bit complex for a simple: if None check.

comment:4 Changed 7 years ago by wmoore

Resolution set to fixed
Status changed from new to closed

https://github.com/openmicroscopy/openmicroscopy/pull/410

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

Download in other formats: