Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #9193 (closed)

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

Bug: group owner add users

Reported by: wmoore Owned by: atarkowska
Priority: critical Milestone: OMERO-4.4
Component: WebAdmin Version: n.a.
Keywords: n.a. Cc: web-team@…, ux-team@…
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2012-07-03 (18)

Description

Group owners should be able to add / remove users from their group, right?

I can't remember if we had this in 4.3, but we don't support it currently (unless I've missed something)?

Change History (11)

comment:1 Changed 7 years ago by atarkowska

  • Owner changed from atarkowska to wmoore

We never allowed group owner to add/remove users from their group. Will, Could you please pass me more details (server tickets, unittests, etc).

comment:2 Changed 7 years ago by atarkowska

  • Owner changed from wmoore to atarkowska
  • Remaining Time set to 0.3

comment:3 Changed 7 years ago by atarkowska

  • Owner changed from atarkowska to wmoore
  • Remaining Time changed from 0.3 to 0.1

Initial changes in 48371337. Passing to you if you to Will to confirm.

comment:4 Changed 7 years ago by wmoore

  • Owner changed from wmoore to atarkowska

Hi Ola - looks great. The only issue is that you can't remove a user from a group that is their default group. I understand that they need to have a default group, but is there any workaround to this? It's not very nice if a group owner has no way to remove a user from their group (since they can't change the default group for a member).

comment:5 Changed 7 years ago by rkferguson

As it is now, the owner can delete user from group unless that group is the user's default group. Then that user is highlighted in blue in the list and the x for delete is absent.

Suggest it would benefit from a single line explanation along the lines of:

"Users highlighted in blue cannot be removed as this is their default group."

comment:6 Changed 7 years ago by rkferguson

  • Cc ux-team@… added

comment:7 Changed 7 years ago by jmoore

If we're not permitting this because the server is throwing an exception on the operation (I don't know that to be true), then I'd say we fix that server-side and then permit the owner from removing the user. It will mean that the user will not be able to login, but that's the result of no group owner (or sysadmin) WANTING the user to be in their group. Sees like that's valid.

comment:8 Changed 7 years ago by atarkowska

  • Status changed from new to accepted

comment:9 Changed 7 years ago by atarkowska

  • Remaining Time changed from 0.1 to 0.5

comment:10 Changed 7 years ago by atarkowska

  • Remaining Time changed from 0.5 to 0
  • Status changed from accepted to closed

allowing user removal from their default group, close #9193

  • possibility of adding/removing users/owners by group owner
  • removing default group and owner marker
  • adding current user marker which prevent from self removal in account settings

implementing add/remove group owner method in a gateway, see #9193

Last edited 7 years ago by atarkowska (previous) (diff)

comment:11 Changed 7 years ago by Aleksandra Tarkowska <A.Tarkowska@…>

(In [48371337385312550c2f4014bc49377ced403459/ome.git] on branch develop) allowing group owner add users, see #9193

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.134572 sec.)

We're Hiring!