Bug: cli group creation

[cblackburn]

More of a check whether help needs updating than a bug,

jrs-macbookpro-25031:dist cblackburn$ bin/omero group add -h
usage: bin/omero group add [-h] [--ignore-existing]
                           [--perms PERMS | --type {private,read-only,collaborative}]
                           name

does the help text need updating or the underlying flag value? ie collaborative to read-annotate

[jmoore]

Thanks for the ticket, Colin. I have this on my last minute TODO list. Just waiting on Emma's suggestion for naming. The same goes for bin/omero group perms as well.

[jmoore]

I put an initial version up on ​https://github.com/openmicroscopy/openmicroscopy/pull/228 for review. Still awaiting the new names. Primary question: Is "collaborative" rwrw or rwra (historically because we downgraded all rwrw groups to rwra, I would say that "collaborative" is rwra. But then what do we call rwrw?)

[sylittlewood]

I'd say that the names of group types should be short and concise as well as expressive for their purpose.

1. private (rw----)
2. read-only (rwr---)
3. read-annotate (rwra--)
4. read-write (rwrw--)

Drop the 'collaborative' nomenclature as it's kind of a given when it's not private. Having the term collaborative confuses things as it encompasses 3 group types now. My recommendation is to be specific and brief with naming.

[jmoore]

Elwood, agreed. I guess my only concern was deprecating since "collaborative" was in the previous version. But certainly open either way.

[eehill]

Whatever we have needs to be called the same thing everywhere, and I think Private, Collaborative: read-only & Collaborative: read-annotate is what is in the clients that we've got for 4.4 at the moment. We need to be consistent, but if there is no time to change, then this should be what we stick with.

[jmoore]

No argument from me there, Emma. The questions are:

• do we still expose "collaborative" as deprecated (sounds like you'd prefer not to)
• do we expect users to type "Collaborative: read-only" on the command-line, or are there shorter versions we can use? (I've used just "read-only" etc. here)

[eehill]

Josh, I think that is fine

[wmoore]

I created a ticket (and PR) for dropping the "Collaborative" from webadmin group permission naming. #9324.

[jmoore]

Yup, already merged for today's build.

[jmoore <josh@…>]

(In [627e3e75975541bc67bb11801b88ee88565429eb/ome.git] on branch develop) Improve group names from bin/omero group (Fix #9290)