Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #9301 (accepted)

Opened 7 years ago

Last modified 4 years ago

replace changePermissions with Chmod

Reported by: jamoore Owned by:
Priority: major Milestone: Permissions
Component: API Version: 5.0.8
Keywords: n.a. Cc: mtbcarroll, cblackburn, web-team
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

There are still a number of places in the code base using IAdmin.changePermissions(group, perms). Though the method has been updated to do what is expected, in the case of a down-grading of read permissions the method could take longer than expected. It would be best to move all uses to omero.cmd.Chmod.

Change History (13)

comment:1 Changed 5 years ago by jburel

  • Cc mtbcarroll cblackburn added
  • Milestone changed from 5.x to 5.1.1
  • Version set to 5.0.8

Moving to 5.1.1
Method IAdmin.changePermissions(group, perms) has been deprecated.

see https://trello.com/c/7rEebfCg/189-test-code-upgrade

comment:2 Changed 5 years ago by mtbcarroll

Might want to save the effort until we have a Chmod2 (which hadn't occurred to me until now); I guess we could plan one for 5.2.

comment:3 Changed 5 years ago by jamoore

Oops, commented on the card. 5.1 would be possible as long as we handle older servers appropriately.

comment:4 Changed 5 years ago by jamoore

  • Milestone changed from 5.1.1 to 5.1.2
  • Owner set to mtbcarroll

comment:5 Changed 5 years ago by mtbcarroll

  • Status changed from new to accepted

At this stage probably best to focus on components/tools/Omero*/ as other code is largely deprecated or rotting.

comment:6 Changed 5 years ago by mtbcarroll

I can fix the integration tests okay but would much appreciate someone familiar with OMERO.web fixing webclient_gateway.py.

comment:7 Changed 5 years ago by mtbcarroll

  • Milestone changed from 5.1.2 to 5.2.0-m1
  • Owner changed from mtbcarroll to cblackburn

At this point it is probably easiest to switch webclient_gateway.py to use Chmod2 for 5.2 only so that 5.1 remains easily compatible. The Python integration test changes included with https://github.com/openmicroscopy/openmicroscopy/pull/3773 may provide helpful examples. The other remaining changePermissions uses that may linger are among only a handful of tests that don't run anyway.

comment:8 Changed 5 years ago by cblackburn

  • Cc web-team added
  • Owner cblackburn deleted

I misunderstood the extent of the work entailed in the final couple of comments when talking to Mark, I'll defer to Will or Ola for looking at fixing what's needed here.

comment:9 Changed 5 years ago by cblackburn

comment:10 Changed 4 years ago by jamoore

  • Milestone changed from 5.2.0 to OMERO-5.2.0

Splitting due to milestone decoupling.

comment:11 Changed 4 years ago by jburel

  • Milestone changed from OMERO-5.2.1 to OMERO-5.2.2

Milestone OMERO-5.2.1 deleted

comment:12 Changed 4 years ago by jburel

  • Milestone changed from OMERO-5.2.2 to OMERO-5.2.1

Milestone OMERO-5.2.2 deleted

comment:13 Changed 4 years ago by jburel

  • Milestone changed from OMERO-5.2.2 to Permissions
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.77109 sec.)

We're Hiring!