Task #9394 (closed)
Webclient plugin "dry"
| Reported by: | wmoore | Owned by: | wmoore |
|---|---|---|---|
| Priority: | major | Milestone: | OMERO-4.4.4 |
| Component: | Web | Version: | n.a. |
| Keywords: | n.a. | Cc: | |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | 2012-07-31 (1) |
Description
Need to apply "Don't Repeat Yourself" practise to init of webclient plugins.
Currently there's a lot of repetition when creating a plugin:
Use a jQuery plugin to handle all the adding of selection change listeners, loading and clearing tab content etc.
User should only have to specify the essentials for their plugin:
- The ID of the content panel
- What objects it supports, E.g. image / dataset etc.
- What to do when we need to load content
Change History (9)
comment:1 Changed 7 years ago by wmoore
comment:2 Changed 7 years ago by wmoore
- Status changed from new to accepted
comment:3 Changed 7 years ago by wmoore
- Resolution set to fixed
- Status changed from accepted to closed
These added a few days ago to handle center plugin:
https://github.com/will-moore/openmicroscopy/commit/4bd4bd6763664100e2bc6be02ffb4e42d9814112
and https://github.com/will-moore/openmicroscopy/commit/faf27dfc9d8317daeec3fdcfbe290cec3ec1f97c
comment:4 Changed 7 years ago by wmoore
New branch for this at https://github.com/will-moore/openmicroscopy/commits/plugin_init_9394
comment:5 Changed 7 years ago by Will Moore <will@…>
(In [bb5b9f59474521b7e554ade5701eebddde3365bb/ome.git] on branch develop) jQuery plugin for right-tab webclient plugin init, See #9394
comment:6 Changed 7 years ago by Will Moore <will@…>
(In [0d774bf2b286959c03661226a4528908f4582ed4/ome.git] on branch develop) Acquisition & Preview plugins init with new plugin. See #9394
comment:7 Changed 7 years ago by Will Moore <will@…>
(In [fa8b7990113a23a597b1ff5b76fb84376199b697/ome.git] on branch develop) right_plugin.general shouldn't auto-select with multi-selection. See #9394
Individual plugins should select tab 0 (batch annotate) if they are the currently selected tab and DONT support
multi-selection. This allows other plugins to support multi-selection if they wish (batch annotate won't be selected automatically
comment:8 Changed 7 years ago by Will Moore <will@…>
(In [19794058fe5a4b6038a380901fa5d38a2e738746/ome.git] on branch develop) Center web-plugin init via jQuery plugin. See #9394
comment:9 Changed 7 years ago by Will Moore <will@…>
(In [6132bcbe34a987aeda54443c36e8dadb27379995/ome.git] on branch develop) Table and Split-view center plugins init via jQuery plugin. See #9394
jQuery plugin (right tabs) is here http://github.com/will-moore/openmicroscopy/commit/3934425fe88f986dcb3b60049a6f2465249f3352
And it's usage by Acquisition and Preview tabs is here http://github.com/will-moore/openmicroscopy/commit/ac809f6b38d8097fd47857131894f4068006680d
Now need to do center plugins