Task #9395 (closed)
Opened 7 years ago
Closed 3 years ago
BUG: omeropy unittests leak
| Reported by: | cneves | Owned by: | cneves |
|---|---|---|---|
| Priority: | critical | Milestone: | Testing2 |
| Component: | OmeroPy | Version: | 4.4.8 |
| Keywords: | n.a. | Cc: | python-team@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
Running each individual unittest from the omeropy suite works fine, but when trying to run the full suit with an open file limit of 1024 it very quickly starts failing every test with 'Too many open files'.
see #7202
Change History (9)
comment:1 Changed 7 years ago by cneves
comment:2 Changed 7 years ago by jmoore
Carlos, which command do you see working with 1536? (And why that number?)
comment:3 Changed 7 years ago by cneves
ICE_CONFIG=~/work/glencoe/omero/github/openmicroscopy/dist/etc/ice.config PYTHONPATH=$PYTHONPATH:.:test/ python setup.py test -s test.gatewaytest
and the number is 1024 (my default) + 512. It's not an exact magical wonderful number that marks the border of possibility land, rather just the first round octal that I tried and worked.
comment:4 Changed 6 years ago by jamoore
- Milestone changed from Unscheduled to Testing and Docs
- Priority changed from major to critical
- Version set to 4.4.8
Is this possibly related to a unittest bug? https://github.com/danielfm/unittest-xml-reporting/issues/30
comment:5 Changed 6 years ago by cneves
With Colin's current branch that has my pytest changes I can run the gateway tests with 1024, but while the situation has improved it is still not resolved, as running all the tests (integration and gateway) in sequence still eventually runs out of file handles, although many of the integration tests are failing in ways that might be provoking the leaks.
It is better, but still needs to be revisited once the integration tests are fixed.
comment:6 Changed 6 years ago by jamoore
- Milestone changed from Testing and Docs to Testing2
Moving to the next round of testing then.
comment:7 Changed 3 years ago by sbesson
Referencing ticket #11622 has changed sprint.
comment:8 Changed 3 years ago by sbesson
Referencing ticket #11622 has changed sprint.
comment:9 Changed 3 years ago by sbesson
- Resolution set to duplicate
- Status changed from new to closed
Captured as part of the gateway integration test review - https://trello.com/c/O37HsEP6/414-gateway-integration-tests-cleanup
With an open file limit of 1536 it works fine for the whole test batch. As there's a lot of sessions being created and destroyed or abandoned (for GC) this might be simple a product of not enough time for GC to do it's thing across the many parts of the system.
The open file count after the tests run isn't increasing from what it was before the test run so this isn't triggering any apparent leak on the omero server portion.
Don't know if it is worth pursuing this issue at the time being.