Task #9422 (closed)
Bug: OMERO.web does not support shape point strings using OME model format
| Reported by: | cxallan | Owned by: | cxallan |
|---|---|---|---|
| Priority: | blocker | Milestone: | OMERO-4.4.4 |
| Component: | Web | Version: | n.a. |
| Keywords: | n.a. | Cc: | web-team@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2012-08-28 (3) |
Description
The OMERO.web stringToSvg() marshaling function does not currently support point strings using the OME model format. As it stands such shapes have completely empty JSON SVG strings being sent to the client.
An example of an OME model point string follows:
1178.6348,1111.9175 1177.283,1111.246 1175.8567,1110.7617 1174.3909,1110.4658...
Change History (9)
comment:1 Changed 12 years ago by cxallan
- Cc web-team@… added
- Owner changed from web-team@… to cxallan
- Remaining Time set to 0.5
- Sprint set to 2012-07-31 (1)
- Status changed from new to accepted
comment:2 Changed 12 years ago by cxallan
- Remaining Time changed from 0.5 to 0.25
comment:3 Changed 12 years ago by cxallan
- Sprint changed from 2012-07-31 (1) to 2012-08-14 (2)
Moved from sprint 2012-07-31 (1)
comment:4 Changed 12 years ago by cxallan
- Sprint changed from 2012-08-14 (2) to 2012-08-28 (3)
comment:5 Changed 12 years ago by cxallan
- Remaining Time changed from 0.25 to 0
- Resolution set to fixed
- Status changed from accepted to closed
comment:6 Changed 12 years ago by cxallan
comment:7 Changed 12 years ago by Chris Allan <callan@…>
(In [74ec53d83c21184997aca14238295fb707916b44/ome.git] on branch develop) Resolve issues with OME model formatted point strings. (See #9422)
This commit includes a fix and refactoring as well as a new WebGateway?
function which allows the marshaling to JSON of a single Shape.
Useful for testing and playing around with individual Shapes. The new
URI syntax is:
webgateway/get_shape_json/<roi_id>/<shape_id>
comment:8 Changed 12 years ago by Chris Allan <callan@…>
(In [325b013e764ddd807250a106321f1675ca4986dc/ome.git] on branch develop) Refactor marshaling and add shape marshal test cases. (See #9422)
There are now compatible top level build targets in the OmeroWeb
component for unit and integration tests. These can be just like the
OmeroPy tests like so:
./build.py -f components/tools/OmeroWeb/build.xml test
Included are also tests for OME-XML model and OMERO.insight shape point
encodings.
comment:9 Changed 12 years ago by Chris Allan <callan@…>
(In [6380ad91ebedeee75bc2afc1db9af8d073c1d564/ome.git] on branch develop) Add a suite.py. (See #9422)
A suite.py is needed to conform more closely to the way in which the
OMERO build system expects to be able to run Python component unit
tests. Additional test packages need to be added to the suite.py in
order to be picked up by the base "test" target of build.py.
Fixes are up on my web-viewer-roi-fixes branch:
Test cases really need to be written to cover all of this before it is merged in.