Bug: TiffParser caching affects output of getComment

[rleigh]

Test case:

import loci.formats.tiff.TiffParser;
import loci.common.RandomAccessInputStream;

class imagedesc
{
    public static void main(String[] args)
    {
	try
	    {
		RandomAccessInputStream stream = new RandomAccessInputStream(args[0]);
		TiffParser tiffParser = new TiffParser(stream);
		tiffParser.setDoCaching(true); // Otherwise getComment() doesn't return the comment.
		//		tiffParser.setDoCaching(false); // Otherwise getComment() doesn't return the comment.

		String imageDescription = tiffParser.getComment();
		System.out.println("DESC: " + imageDescription);
	    }
	catch (Exception e)
	    {
	    }
    }
}

Run with sample TIFF file as argument; I used

java imagedesc from_skyking/leica-scn/mihaela/UCLAD_0000000280_2011-02-10\ 13_32_55Z.scn

With caching enabled:

<?xml version="1.0"?>
<scn xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" uuid="urn:uuid:2dfe8a1b-05f8-43ee-a71a-8b8ad8cc2275" xmlns="http://www.leica-microsystems.com/scn/2010/03/10">
  <collection
...

With caching disabled:

tag = 270, type = ASCII, count = 2448, offset = 1632797070

The latter is the output of TiffIFDEntry::toString() rather than the actual IMAGE_DESCRIPTION as expected. I can't yet see where the bug lies, but I would certainly expect getComment() to return the same data whether or not caching was enabled or disabled.

Roger

[mlinkert]

Should be fixed with: ​https://github.com/melissalinkert/bioformats/commit/769ce9eeed90b20544c57bba65eb986b23e8a2d9