Task #9469 (closed)
Bug: Insight silently renames exported files where the file already exists
| Reported by: | rleigh | Owned by: | jburel |
|---|---|---|---|
| Priority: | major | Milestone: | OMERO-4.4.7 |
| Component: | Insight | Version: | n.a. |
| Keywords: | n.a. | Cc: | ux@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2013-05-07 (8) |
Description
If I export to OME TIFF a file named, for example "image.ome.tiff", and the file already exists, Insight will save a file named "image_(1).ome.tiff.
I think it would be safer and more reliable to tell the user that the file already exists, and to ask them whether or not to overwrite it. If the user says no, then just return them to the file selection so they can choose another name.
I think that silently saving under another name is second-guessing the intentions of the user, and not doing what they asked, without informing them of the fact. The user is unaware that the file they exported has been renamed, and they may then use the file without knowing that it's actually the wrong file.
Roger
Change History (15)
comment:1 Changed 12 years ago by jburel
- Cc ux@… added
- Milestone changed from Unscheduled to OMERO-4.5
- Priority changed from minor to major
- Remaining Time set to 0.4
- Sprint set to 2012-11-20 (2)
- Status changed from new to accepted
comment:2 Changed 12 years ago by jmoore
comment:3 Changed 12 years ago by jburel
For that one, we should probably follow the same logic than the one implemented when saving the image as jpeg png i.e. check that a file with same name already exists
comment:4 Changed 12 years ago by rleigh
I would argue that the behaviour is equally broken in web browsers, and that this is not a model to emulate.
comment:5 Changed 12 years ago by jburel
- Sprint changed from 2012-11-20 (2) to 2012-12-18 (3)
Moved from sprint 2012-11-20 (2)
comment:6 Changed 12 years ago by jburel
- Owner jburel deleted
- Status changed from accepted to new
comment:7 Changed 12 years ago by mtbcarroll
- Owner set to mtbcarroll
- Status changed from new to accepted
comment:8 Changed 12 years ago by jburel
- Sprint changed from 2012-12-18 (3) to 2013-01-15 (4)
Moved from sprint 2012-12-18 (3)
comment:9 Changed 12 years ago by jburel
- Sprint changed from 2013-01-15 (4) to 2013-02-12 (5)
Moved from sprint 2013-01-15 (4)
comment:10 Changed 12 years ago by jburel
- Sprint changed from 2013-02-12 (5) to 2013-03-12 (6))
Moved from sprint 2013-02-12 (5)
comment:11 Changed 12 years ago by jburel
- Sprint changed from 2013-03-12 (6)) to 2013-04-09 (7))
Moved from sprint 2013-03-12 (6))
comment:12 Changed 11 years ago by mtbcarroll
- Owner changed from mtbcarroll to jburel
FS work is preventing my getting much back-burner Insight time at present.
comment:13 Changed 11 years ago by jburel
- Sprint changed from 2013-04-09 (7)) to 2013-05-07 (8)
Moved from sprint 2013-04-09 (7))
comment:14 Changed 11 years ago by jburel
- Remaining Time changed from 0.4 to 0
- Resolution set to fixed
- Status changed from accepted to closed
comment:15 Changed 11 years ago by Blazej Pindelski <bpindelski@…>
(In [03c318a3cf21383c469cac3e2cadc0c87e1a34fa/ome.git] on branch develop) Do not rename the ome-tiff file silently (see #9469)
I would tend to agree, but most browsers do the same. The difference being that the downloads all go to the same directory, so a user typically sorts by date. We should just be clear on what model we're following.