Task #9473 (closed)
Lim: NominalMagnification can't represent non-integer magnifications
| Reported by: | rleigh | Owned by: | ajpatterson |
|---|---|---|---|
| Priority: | critical | Milestone: | 5.0.0-beta1 |
| Component: | Specification | Version: | n.a. |
| Keywords: | schema, xsd-2013-1 | Cc: | ajpatterson, jburel, mlinkert |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
NominalMagnification? is a PositiveInt?. This means you can't represent non-integer magnifications, e.g. 1.5x, 2.5x, 0.6x.
For slide scanners, the low resolution overview scan can be <1x. For the Leica SCN400, this is 0.60833x, for example.
Please could NominalMagnification? be changed to PositiveFloat? in order to allow these objective magnifications to be represented in the model?
Thanks,
Roger
Change History (10)
comment:1 Changed 7 years ago by rleigh
comment:2 Changed 7 years ago by jmoore
- Cc ajpatterson jburel added
- Component changed from Model to Specification
- Milestone changed from Unscheduled to OMERO-4.5
- Priority changed from major to critical
comment:3 Changed 7 years ago by mlinkert
- Cc mlinkert-x added
comment:4 Changed 7 years ago by ajpatterson
A change of NominalMagnification from integer to float could be done in a Minor schema release.
A change of CalibratedMagnification from float to PositiveFloat (or NonNegativeFloat if Zero is allowed) would need a Major schema release.
comment:5 Changed 7 years ago by ajpatterson
- Summary changed from Bug: NominalMagnification can't represent non-integer magnifications to Lim: NominalMagnification can't represent non-integer magnifications
comment:6 Changed 7 years ago by ajpatterson
- Keywords schema added
comment:7 Changed 7 years ago by ajpatterson
- Owner set to ajpatterson
comment:8 Changed 6 years ago by ajpatterson
- Keywords xsd-2013-1 added
- Status changed from new to accepted
comment:9 Changed 6 years ago by ajpatterson
- Resolution set to fixed
- Status changed from accepted to closed
comment:10 Changed 6 years ago by Andrew J Patterson <workonly@…>
(In [e01230d18253e2a10d66041787b149f202f22752/ome.git] on branch develop) Convert NominalMagnification? into Float, see #9473
Additionally, with respect to CalibratedMagnification?, this is of type "float". Could this be changed to PositiveFloat?? A negative value makes no sense here since anything between zero and one is a minification. Negative is invalid.