Task #9559 (closed)
Bug: ROI support model
| Reported by: | jburel | Owned by: | jburel |
|---|---|---|---|
| Priority: | major | Milestone: | OMERO-4.4.4 |
| Component: | Insight | Version: | n.a. |
| Keywords: | n.a. | Cc: | cxallan, wmoore |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2012-09-11 (4) |
Description (last modified by jburel)
If the shape does not have a Z or a T specified, the shape should be displayed on all z-section/timepoints.
- Add support for polyline and polygon following the specification.
Attachments (4)
Change History (20)
comment:1 Changed 7 years ago by jburel
- Remaining Time set to 0.4
- Status changed from new to accepted
comment:2 Changed 7 years ago by jburel
- Description modified (diff)
- Remaining Time changed from 0.4 to 0.8
comment:3 Changed 7 years ago by jburel
- leave the field displaying z (resp. t) blank when the value is null. Same for ROI or Shape
- if Shape has z (resp. t) not null, indicate the value (as it is now). ROI display 'range' i.e. min-max if min and max are not the same (only the case for multiple shapes)
- Type field: if Shape of the same type (e.g. line), the ROI will display the shape type. If shape of different types, the ROI will not display a shape's type. Same for text.
Changed 7 years ago by jburel
comment:4 Changed 7 years ago by jburel
- Summary changed from Bug: ROI w/o z or t to Bug: ROI support model
Follow the list done while working on that ticket.
- Fix display of z, t, type in inspector
- Add support for polyline and polygon following the specification.
- Prepare code to display shape w/o z or t.
- Fix the saving of shape so that null z or null t are not replaced by a default value.
I had to turn off the display of shapes w/o z or t since the measurement tool currently does not support multiple shapes per roi. This is out of the scope of that ticket.
I attach a sample file with Shape
Changed 7 years ago by jburel
comment:5 Changed 7 years ago by jburel
- Remaining Time changed from 0.8 to 0
- Resolution set to fixed
- Status changed from accepted to closed
comment:6 Changed 7 years ago by wmoore
https://github.com/openmicroscopy/openmicroscopy/pull/331 for Web (see screenshots above)
comment:7 Changed 7 years ago by jburel <j.burel@…>
(In [4683965fbab86ca010652b8d4f93f23f83d7b2c6/ome.git] on branch develop) Support polyline following specification for points (see #9559)
Add support for both i.e. points[10,10] and 10,10
add tests
comment:8 Changed 7 years ago by jburel <j.burel@…>
(In [bafb7d12cbe0e288b3c93ac16c29d3dd73444033/ome.git] on branch develop) Do not insert negative z or t if null (see #9559)
comment:9 Changed 7 years ago by jburel <j.burel@…>
(In [c9eb7dda7c0215deaa8bbb5a1792be1fcf28cd7d/ome.git] on branch develop) Add shape w/o z and t to the drawing. (see #9559)
comment:10 Changed 7 years ago by jburel <j.burel@…>
(In [74f84d9b28aa2455b9f6c1f686ecadc891b66879/ome.git] on branch develop) Fix ROI/Shape display following discussion (see #9559)
comment:11 Changed 7 years ago by jburel <j.burel@…>
(In [4464c6bbf647b825e6d04667aa00322ebecf8794/ome.git] on branch develop) Do not select a new plane when z or t < 0 (see #9559)
comment:12 Changed 7 years ago by jburel <j.burel@…>
(In [914e49a9509f6bf54235c226628783ee2dbca4c6/ome.git] on branch develop) Save bug introduced while saving the z/t of the shape. (see #9559)
comment:13 Changed 7 years ago by jburel <j.burel@…>
(In [08fffd711e6ad7dc245c32d85732869234f77059/ome.git] on branch develop) Do not display shape w/o z or t. (see #9559)
comment:14 Changed 7 years ago by Will Moore <will@…>
(In [009d5b6c31938ab03c37f552d9a9de507c937134/ome.git] on branch develop) Remove 'All' text and don't set Z/T pos if no Z/T on clicked shape. See #9559
comment:15 Changed 7 years ago by Will Moore <will@…>
(In [0ed5d25e99a3e6eb73c44e3e072a8a415e235833/ome.git] on branch develop) ROI Z/T range not shown if any shape has Z/T null. See #9559
comment:16 Changed 7 years ago by Will Moore <will@…>
(In [966a42f89e24dc0027f445215d9291c968e8cba5/ome.git] on branch develop) ROI table handles mixture of Shape types & labels. See #9559
