Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #9561 (closed)

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

Call close on Cmd callbacks etc

Reported by: wmoore Owned by: wmoore
Priority: major Milestone: OMERO-4.4.4
Component: Web Version: n.a.
Keywords: n.a. Cc: cxallan, cneves, jamoore
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: 2012-09-11 (4)

Description

Josh: Either the handle or a callback holding the handle must be closed. This is made a bit tricky in the webclient. Handle is proxy object, which can be string-ified and re-created later. You don't want to call before you're completely finished with it. The close(bool) method on CmdCallback? will call close on the handle if you pass True.

See https://github.com/cneves/openmicroscopy/commit/6a882500880a23304b150fa533ae18eb970bba54#commitcomment-1780969

Change History (2)

comment:1 Changed 7 years ago by wmoore

  • Resolution set to fixed
  • Status changed from new to closed

Call close on the chgrp callback: See https://github.com/openmicroscopy/openmicroscopy/pull/342 (scripts and delete were already calling close).

comment:2 Changed 7 years ago by Will Moore <will@…>

(In [b687b68eeb1344675db8ae5313ff0307f29e5c6e/ome.git] on branch develop) Call close on chgrp callback. See #9561

We already call close on the scripts callback, although we don't do close(False) since
this is not a omero.cmd.HandlePrx?

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.82739 sec.)

We're Hiring!