Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #9565 (closed)

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

Bug: XML Sample file not valid

Reported by: jburel Owned by: ajpatterson
Priority: major Milestone: OMERO-4.4.4
Component: Specification Version: n.a.
Keywords: n.a. Cc: cxallan
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: 2012-09-11 (4)

Description

while testing ROI I had a closer look at the XML file with ROI
i.e. 6x4y1z1t1c8b-swatch-downgrade.ome
The sample file is not correct i.e.

<OME:Pixels DimensionOrder="XYCZT" ID="Pixels:0:0" PhysicalSizeX="10000.0"
			PhysicalSizeY="10000.0" Type="uint8" SizeC="3" SizeT="1" SizeX="6" SizeY="4" SizeZ="1">

Since the size of T and Z is 1, the theZ and theT should be 0 not 1.

<ROI:Shape ID="Shape:4" FillRule="EvenOdd" FontStyle="Normal" FontFamily="serif"
				Text="Hello" FillColor="1" FontSize="1" LineCap="Butt" StrokeColor="1"
				StrokeDashArray="10 10" StrokeWidth="1" TheC="1" TheT="1" TheZ="1" Visible="true">

Other similar samples files need to be reviewed.

Change History (6)

comment:1 Changed 12 years ago by ajpatterson

Only this file:

components/specification/Samples/OmeFiles/2012-06/6x4y1z1t1c8b-swatch-downgrade.ome

and its output after the downgrade

components/specification/Samples/OmeFiles/2011-06/output.ome

are affected.

Last edited 12 years ago by ajpatterson (previous) (diff)

comment:2 Changed 12 years ago by ajpatterson

http://github.com/openmicroscopy/openmicroscopy/pull/345 for develop

and

http://github.com/openmicroscopy/openmicroscopy/pull/346 for schema-2012-06 (but just as a placeholder - it needs cherry picked)

comment:3 Changed 12 years ago by ajpatterson

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 12 years ago by ajpatterson

Got cherry pick to work, commit for schema-2012-06 now on PR
http://github.com/openmicroscopy/openmicroscopy/pull/272

comment:5 Changed 12 years ago by Andrew J Patterson <workonly@…>

(In [4e3053c755a4a54fe74ea2863bb8d87fe2597a26/ome.git] on branch develop) Fix off-by-one error in T/Z/C of ROIs, see #9565

Also added a couple more lines to readme file.

comment:6 Changed 12 years ago by Josh Moore <josh@…>

(In [b319a8ceea463f1a213743a2537a2a537a1aeef8/ome.git] on branch develop) Merge pull request #345 from qidane/develop-9565-fix

Fix off-by-one error in T/Z/C of ROIs, see #9565

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.65376 sec.)

We're Hiring!