Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #9601 (closed)

Opened 12 years ago

Closed 12 years ago

Bug: ant test targets use wrong classpath

Reported by: mhiner-x Owned by: mhiner-x
Priority: minor Milestone: OMERO-4.4.7
Component: Bio-Formats Version: n.a.
Keywords: n.a. Cc: crueden-x, mlinkert
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

Some components (notably /components/bio-formats) that define a custom "test" target in their build.xml reference an incorrect classpath:
${component}.classpath

when they should use:
${component}.runtime-cp

This results in build failure due to missing logging jars when the tests are run.

Change History (4)

comment:1 Changed 12 years ago by mhiner-x

In addition to not referencing ${component}.runtime-cp, in some cases the runtime-cp does not include the required slf4j jars.

comment:3 Changed 12 years ago by mhiner-x

Note that the runtime-cp was missing required slf4j jars because they were intended to be transitively inherited via dependent jar classpaths. However, there was therefore an unenforced dependency upon the copy-jars target.. so that copy-jars, or some target that depended upon copy-jars, needed to be executed before trying to run any tests.

In response, a general "testing-deps" target was added to ensure copy-jars is always run before a test.

see: https://github.com/melissalinkert/bioformats/pull/9

comment:4 Changed 12 years ago by mhiner-x

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.66741 sec.)

We're Hiring!