Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #9610 (closed)

Opened 10 years ago

Closed 7 years ago

Bug: rdef and ann graph issues

Reported by: jamoore Owned by:
Priority: major Milestone: 5.1.1
Component: Security Version: 4.4.8
Keywords: BACKPORT-4.4 Cc: cxallan, ux@…
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

#9496 describes issues with MOVE'ing graphs containing rdefs into private groups. Similar issues likely exist for annotations. Several tests are left failing in OmeroJava/test/integration with "#9496" and these should be handled by this ticket.

Change History (16)

comment:1 Changed 9 years ago by jamoore

  • Owner set to jamoore
  • Version set to 4.4.8

comment:2 Changed 9 years ago by mtbcarroll

Given http://trac.openmicroscopy.org.uk/ome/ticket/10419#comment:3 I wonder if that ticket is a subset of this.

comment:3 Changed 9 years ago by jamoore

Quite likely.

comment:4 Changed 9 years ago by jamoore

  • Milestone changed from OMERO-4.4.9 to OMERO-4.4.10

Added to known limitations for 4.4.9. Pushing to 4.4.10 with other
security & graph issues.

comment:5 Changed 8 years ago by mtbcarroll

  • Cc mtbcarroll added

comment:6 Changed 8 years ago by jamoore

  • Owner changed from jamoore to mtbcarroll

comment:7 Changed 8 years ago by jburel

  • Milestone changed from 5.1.0 to 5.1.0-m4

moving to m4

comment:8 Changed 8 years ago by mtbcarroll

The graphs reimplementation for #11779 presently fails here too: it moves the other user's rendering settings into the private group, then can no longer see that they exist. Simply deleting others' rendering settings on chgrp would easily work around this for now, but all the best solutions involve a grander reworking that allows looking ahead to who can see what after the chgrp. This is perhaps easier now that GraphTraversal can now ask ACLVoter about permissions based on Details instances it constructed itself.

comment:9 Changed 8 years ago by mtbcarroll

I don't know how this relates to the tests, but a reasonable target for 5.1.0-m3 might be to delete others' rendering settings, thumbnails, ROIs, if the image is moved into a private group.

comment:10 Changed 8 years ago by mtbcarroll

AnnotationMoveTest and HierarachyMoveAndPermissionsTest still have some failures that may relate to this ticket.

comment:11 Changed 8 years ago by mtbcarroll

comment:12 Changed 7 years ago by mtbcarroll

  • Cc ux@… added; wmoore jburel mtbcarroll removed
  • Milestone changed from 5.1.0-m4 to 5.1.1
  • Priority changed from critical to major

https://github.com/openmicroscopy/openmicroscopy/pull/3327 addresses further issues regarding moving into private groups.

At this point remaining work is predicated on a larger study of who should be able to move what: for instance, group owners moving members' images, members moving images among read-write groups, etc. Once UX requirements are drawn up as part of the larger permissions review, further implementation could proceed.

comment:13 Changed 7 years ago by mtbcarroll

  • Owner mtbcarroll deleted

comment:14 Changed 7 years ago by jamoore

Referencing ticket #11752 has changed sprint.

comment:15 Changed 7 years ago by jamoore

Referencing ticket #11752 has changed sprint.

comment:16 Changed 7 years ago by mtbcarroll

  • Resolution set to duplicate
  • Status changed from new to closed

https://trello.com/c/KluUDJDK/328-keep-failing-tests-on-radar and the 5.1.x graphs review work, which will include UX in the loop as described in https://trello.com/c/PZeCDbjf/186-graphs-review-chgrp-chown-delete, cover the remainder of this ticket.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.88051 sec.)

We're Hiring!