Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #9689 (closed)

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

Web dialog duplication

Reported by: wmoore Owned by: wmoore
Priority: major Milestone: OMERO-4.4.7
Component: Web Version: n.a.
Keywords: n.a. Cc:
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2012-10-23 (1)

Description

Currently when we create a jQuery ui dialog from E.g. <form id="choose_attachments_form"> when the right-hand panel loads. Then, we load another page into the right-hand panel and we get another dialog generated. The original one is still attached to the <body> since it is not removed when the right hand panel content is refreshed.

This leads to many dialog elements getting attached to the page <body> durning browsing.

Solution is to remove these dialog contents elements from each right-hand panel and create them when we init the dialog IF they don't already exist.

Attachments (1)

Screen shot 2012-10-01 at 12.21.31.png (158.4 KB) - added by wmoore 7 years ago.
Edit Share, close dialog with 'X' then edit another share and 'Cancel'

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by wmoore

  • Status changed from new to accepted

Changed 7 years ago by wmoore

Edit Share, close dialog with 'X' then edit another share and 'Cancel'

comment:2 Changed 7 years ago by wmoore

  • Remaining Time changed from 2 to 0
  • Resolution set to fixed
  • Status changed from accepted to closed
Last edited 7 years ago by wmoore (previous) (diff)

comment:3 Changed 7 years ago by Will Moore <will@…>

(In [c5dc96775781143208cb4a2d608498b7c47e4ba0/ome.git] on branch develop) Tags & Attachments dialogs don't duplicate. See #9689

If the <form> element with correct id already exists, simply reuse it. Don't create a new
one each time the right-hand panel loads.

comment:4 Changed 7 years ago by Will Moore <will@…>

(In [a007ff88bf1941794640a92ded8a0010bbdd25ea/ome.git] on branch develop) Batch Annotate re-uses Tag and Files dialogs. See #9689

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.77482 sec.)

We're Hiring!