Task #9695 (closed)
BUG:QA4652 - statsinfo can be null
Reported by: | omero-qa | Owned by: | wmoore |
---|---|---|---|
Priority: | major | Milestone: | OMERO-4.4.7 |
Component: | Web | Version: | n.a. |
Keywords: | n.a. | Cc: | dennis@… |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description
qa 4652 which is related to ticket 9655. To prevent errors like this, we will need to assume that statsinfo can be null everywhere.
("error in call","Traceback (most recent call last): File "/usr/omero/lib/python/omeroweb/webgateway/views.py", line 1013, in wrap rv = f(request, *args, **kwargs) File "/usr/omero/lib/python/omeroweb/webgateway/views.py", line 1121, in imageData_json rv = imageMarshal(image, key) File "/usr/omero/lib/python/omeroweb/webgateway/marshal.py", line 135, in imageMarshal rv['channels'] = map(lambda x: channelMarshal(x), image.getChannels()) File "/usr/omero/lib/python/omeroweb/webgateway/marshal.py", line 135, in <lambda> rv['channels'] = map(lambda x: channelMarshal(x), image.getChannels()) File "/usr/omero/lib/python/omeroweb/webgateway/marshal.py", line 45, in channelMarshal return {'emissionWave': channel.getEmissionWave(), File "/usr/omero/lib/python/omero/gateway/__init__.py", line 5455, in getWindowMin return self._obj.getStatsInfo().getGlobalMin().val AttributeError: 'NoneType' object has no attribute 'getGlobalMin' ")
Change History (6)
comment:1 Changed 12 years ago by jmoore
- Component changed from from QA to Web
- Milestone changed from Unscheduled to OMERO-4.5
- Priority changed from minor to major
comment:2 Changed 12 years ago by jmoore
Possibly also http://qa.openmicroscopy.org.uk/qa/feedback/4653/
comment:3 Changed 12 years ago by wmoore
- Resolution set to fixed
- Status changed from new to closed
In https://github.com/will-moore/openmicroscopy/tree/sprint2-web-bugs handle getStatsInfo() nulls in Blitz Gateway: https://github.com/will-moore/openmicroscopy/commit/f13de2a387a5eeaab6f55563867b8edfee487030
comment:4 Changed 12 years ago by jmoore
@wmoore, would it have been worth it to put a method in place for these actions?
comment:5 Changed 11 years ago by Will Moore <will@…>
(In [a6c1dfa45ee5c5519df3a0769f116a004a86c056/ome.git] on branch develop) Blitz handles nulls for getStatsInfo() See #9695
getWindowMin() and getWindowMax() will return None if getStatsInfo() is None
comment:6 Changed 11 years ago by Will Moore <will@…>
(In [612797660bab10f6dad2db04b1fbc869afc4c31e/ome.git] on branch develop) Use pixelType when getStatsInfo() is null. See #9695
Note: this would also be an candidate for inclusion in 4.4.x.