BUG: Folder name shows as dataset in import window

[cblackburn]

If I import a folder of images into a P/D the folder name shows instead of the Dataset in the queue item. The images import into the correct location without problem.

[jburel]

Passing on to elwood as part of the work done on the import component.

[jburel]

Moved from sprint 2012-12-18 (3)

[jburel]

Moved from sprint 2013-01-15 (4)

[jburel]

Moved from sprint 2013-02-12 (5)

[jburel]

Moved from sprint 2013-03-12 (6))

[jburel]

Moved from sprint 2013-04-09 (7))

[jburel]

Moved from sprint 2013-05-07 (8)

[jburel]

Need to be fixed this time.

[mtbcarroll]

There is an issue with FileSelectionTable.addFiles:

	if (f.isDirectory()) {
		value = f.getName();
		v = fad;
		if (model.getType() == Importer.SCREEN_TYPE) {
			value = null;
		}
	} else {
		if (fad) {
			value = f.getParentFile().getName();
			v = true;
			element.setToggleContainer(v);
		}
	}

I am not sure how sufficiently these conditionals' actions cover the truth table for fad, f.isDirectory(), model.getType() == Importer.SCREEN_TYPE, nor even which combinations are possible. It is clear that the bug arises from value being set to the directory name when those are false, true, false, but I am not sure if any other combinations also give a wrong outcome, and I don't know if it is important that value does get set in this case and that nulling it won't have some bad side effect. @jburel, any thoughts?

[jburel]

Mark do you want me to have a look? Few things were not cleaned up after the first round of major changes.

[mtbcarroll]

Yes, I'd welcome that, thank you. If I adjust the quoted conditional then the bug is fixed. If that's the right thing to do, then I'm worried about if the conditional is wrong for other cases too. If that's the wrong thing to do, then perhaps it's the rendering of the DataNodeElement that needs adjusting instead.

[jburel]

see ​https://github.com/openmicroscopy/openmicroscopy/pull/1702