Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #9770 (closed)

Opened 12 years ago

Closed 11 years ago

BUG: Insight - right-click menu

Reported by: pwalczysko Owned by: jburel
Priority: critical Milestone: OMERO-4.4.9
Component: Insight Version: 4.4.8
Keywords: n.a. Cc: ux@…, rleigh, mtbcarroll
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: Blocker 4.4.9 (1)

Description (last modified by pwalczysko)

Downloaded OMERO.Insight from the newest Howe build. OMERO.insight-4.4.4-92-ae07c89-dirty-ice33-b30-mac. The same bug is also in the version downloaded from OME webpage OMERO.clients-4.4.4-ice33-b3099.mac In the left part of DataManager?, under Projects pane. Select a Dataset. Right-click and select "New...". Instead of "Create Project" window a new "Import" window appears. "Import" is the menu item just above the "New....". The bug is intermittent at times. It is not there just after logging in into Insight. In case the bug is not present at the moment, go select image-right-click-select "New dataset from Selection" and cancel the opened window. In vast majority of cases, this is sufficient to make the bug appear, this means go select Dataset-right-click-New... and Import window appears now.
If problems seeing the bug still persist, do it in a read-annotate group, select dataset-right-click-select "New..." and again Import window appears. If the bug does not appear, try to switch between groups, have at least one read-only and one read-annotate group. Make only the read-only group visible, and make the read-annotate group visible later. After trying this, go again select image-right-click-"New dataset from Selection" and cancel the appearing window. Then go select dataset-right-click-New... and the bug (=Import window) should appear.
See also a video on squib Petr/19-10-12/001

Change History (27)

comment:1 Changed 12 years ago by pwalczysko

  • Description modified (diff)

comment:2 Changed 12 years ago by pwalczysko

  • Description modified (diff)

comment:3 Changed 12 years ago by jburel

  • Sprint changed from 2012-10-23 (1) to 2012-11-20 (2)

Moved from sprint 2012-10-23 (1)

comment:4 Changed 12 years ago by pwalczysko

  • Description modified (diff)

comment:5 Changed 12 years ago by bpindelski

  • Owner changed from jburel to bpindelski

comment:6 Changed 12 years ago by bpindelski

  • Remaining Time set to 0.5
  • Status changed from new to accepted

comment:7 Changed 12 years ago by bpindelski

After debugging it has been discovered, that a wrong object type is being passed into org.openmicroscopy.shoola.agents.treeviewer.cmd.CreateCmd?. After starting insight, the "New..." entry in the popup menu will allow for creating a new Project. The passed in userObject type is ProjectData?. After doing what Petr suggested, i.e. creating a new dataset from an image, the behavior changes. Clicking "New..." indeed hits CreateCmd?, but the userObject type is ImageData? (pojos.ImageData? (id=-1)). There might be a synch issue here. Probably the userObject is still the reference to the image used to create the dataset.

Last edited 12 years ago by bpindelski (previous) (diff)

comment:8 Changed 12 years ago by bpindelski

  • Owner changed from bpindelski to jburel
  • Remaining Time 0.5 deleted

comment:9 Changed 12 years ago by pwalczysko

There is another turn on this.
Downloaded OMERO.insight-4.4.4-158-ba0fad6-dirty-ice33-b50-mac.
On Howe.
Logged in as user-7, then user-1, user-3 - all have the same problem.
Started with being user-7 and tagging user-1's images.
Then the first crash happened.
Full crash with error warning, Insight closes automatically.
The error warning is so shortly on the screen that I cannot manage to catch it and copy the exceptions.
The same repeats when trying to Create a new tag on own data's, for all the abovementioned user's.
It happens when the new tag is created at import.
It happens also when the new tag is created on imported images using right-click.
The Pull-request on Github 448, which is connected to the 9812 bug, solves slightly different problem possibly.
Here is the log of one of the crashes:

2012-11-02 13:22:42,677 FATAL [icroscopy.shoola.env.AbnormalExitHandler] (entQueue-0) Abnormal termination due to an uncaught exception.
java.lang.IllegalArgumentException: Object cannot null.
	at pojos.ExperimenterData.<init>(ExperimenterData.java:78)
	at pojos.DataObject.getOwner(DataObject.java:290)
	at org.openmicroscopy.shoola.agents.util.DataObjectListCellRenderer.getListCellRendererComponent(DataObjectListCellRenderer.java:292)
	at javax.swing.plaf.basic.BasicListUI.updateLayoutState(BasicListUI.java:1344)
	at javax.swing.plaf.basic.BasicListUI.maybeUpdateLayoutState(BasicListUI.java:1294)
	at javax.swing.plaf.basic.BasicListUI.getPreferredSize(BasicListUI.java:561)
	at javax.swing.JComponent.getPreferredSize(JComponent.java:1642)
	at javax.swing.ScrollPaneLayout.layoutContainer(ScrollPaneLayout.java:769)
	at java.awt.Container.layout(Container.java:1419)
	at java.awt.Container.doLayout(Container.java:1408)
	at java.awt.Container.validateTree(Container.java:1505)
	at java.awt.Container.validate(Container.java:1478)
	at javax.swing.RepaintManager.validateInvalidComponents(RepaintManager.java:670)
	at javax.swing.RepaintManager$ProcessingRunnable.run(RepaintManager.java:1671)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:702)
	at java.awt.EventQueue.access$400(EventQueue.java:82)
	at java.awt.EventQueue$2.run(EventQueue.java:663)
	at java.awt.EventQueue$2.run(EventQueue.java:661)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:672)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:205)
	at java.awt.Dialog$1.run(Dialog.java:1044)
	at java.awt.Dialog$3.run(Dialog.java:1096)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.awt.Dialog.show(Dialog.java:1094)
	at java.awt.Component.show(Component.java:1591)
	at java.awt.Component.setVisible(Component.java:1543)
	at java.awt.Window.setVisible(Window.java:843)
	at java.awt.Dialog.setVisible(Dialog.java:984)
	at org.openmicroscopy.shoola.util.ui.UIUtilities.centerAndShow(UIUtilities.java:558)
	at org.openmicroscopy.shoola.agents.metadata.editor.EditorComponent.showSelectionWizard(EditorComponent.java:154)
	at org.openmicroscopy.shoola.agents.metadata.editor.EditorComponent.setExistingTags(EditorComponent.java:278)
	at org.openmicroscopy.shoola.agents.metadata.TagsLoader.handleResult(TagsLoader.java:106)
	at org.openmicroscopy.shoola.env.data.events.DSCallAdapter.eventFired(DSCallAdapter.java:90)
	at org.openmicroscopy.shoola.env.data.views.BatchCallMonitor$1.run(BatchCallMonitor.java:124)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:702)
	at java.awt.EventQueue.access$400(EventQueue.java:82)
	at java.awt.EventQueue$2.run(EventQueue.java:663)
	at java.awt.EventQueue$2.run(EventQueue.java:661)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:672)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
Abnormal termination due to an uncaught exception.
java.lang.IllegalArgumentException: Object cannot null.
	at pojos.ExperimenterData.<init>(ExperimenterData.java:78)
	at pojos.DataObject.getOwner(DataObject.java:290)
	at org.openmicroscopy.shoola.agents.util.DataObjectListCellRenderer.getListCellRendererComponent(DataObjectListCellRenderer.java:292)
	at javax.swing.plaf.basic.BasicListUI.updateLayoutState(BasicListUI.java:1344)
	at javax.swing.plaf.basic.BasicListUI.maybeUpdateLayoutState(BasicListUI.java:1294)
	at javax.swing.plaf.basic.BasicListUI.getPreferredSize(BasicListUI.java:561)
	at javax.swing.JComponent.getPreferredSize(JComponent.java:1642)
	at javax.swing.ScrollPaneLayout.layoutContainer(ScrollPaneLayout.java:769)
	at java.awt.Container.layout(Container.java:1419)
	at java.awt.Container.doLayout(Container.java:1408)
	at java.awt.Container.validateTree(Container.java:1505)
	at java.awt.Container.validate(Container.java:1478)
	at javax.swing.RepaintManager.validateInvalidComponents(RepaintManager.java:670)
	at javax.swing.RepaintManager$ProcessingRunnable.run(RepaintManager.java:1671)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:702)
	at java.awt.EventQueue.access$400(EventQueue.java:82)
	at java.awt.EventQueue$2.run(EventQueue.java:663)
	at java.awt.EventQueue$2.run(EventQueue.java:661)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:672)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:205)
	at java.awt.Dialog$1.run(Dialog.java:1044)
	at java.awt.Dialog$3.run(Dialog.java:1096)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.awt.Dialog.show(Dialog.java:1094)
	at java.awt.Component.show(Component.java:1591)
	at java.awt.Component.setVisible(Component.java:1543)
	at java.awt.Window.setVisible(Window.java:843)
	at java.awt.Dialog.setVisible(Dialog.java:984)
	at org.openmicroscopy.shoola.util.ui.UIUtilities.centerAndShow(UIUtilities.java:558)
	at org.openmicroscopy.shoola.agents.metadata.editor.EditorComponent.showSelectionWizard(EditorComponent.java:154)
	at org.openmicroscopy.shoola.agents.metadata.editor.EditorComponent.setExistingTags(EditorComponent.java:278)
	at org.openmicroscopy.shoola.agents.metadata.TagsLoader.handleResult(TagsLoader.java:106)
	at org.openmicroscopy.shoola.env.data.events.DSCallAdapter.eventFired(DSCallAdapter.java:90)
	at org.openmicroscopy.shoola.env.data.views.BatchCallMonitor$1.run(BatchCallMonitor.java:124)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:702)
	at java.awt.EventQueue.access$400(EventQueue.java:82)
	at java.awt.EventQueue$2.run(EventQueue.java:663)
	at java.awt.EventQueue$2.run(EventQueue.java:661)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:672)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
Exception in thread "AWT-EventQueue-0"

comment:10 Changed 12 years ago by jburel

  • Sprint changed from 2012-11-20 (2) to 2012-12-18 (3)

Moved from sprint 2012-11-20 (2)

comment:11 Changed 12 years ago by jburel

  • Owner jburel deleted
  • Status changed from accepted to new

comment:12 Changed 12 years ago by jburel

  • Owner set to jburel

comment:13 Changed 12 years ago by jburel

  • Sprint 2012-12-18 (3) deleted

comment:14 Changed 12 years ago by pwalczysko

Re-occured again during testing of 4.4.6 release (no crash, just the menu item mismatch). Reported by @ rleigh.

Last edited 12 years ago by pwalczysko (previous) (diff)

comment:15 Changed 12 years ago by pwalczysko

  • Cc ux@… rleigh added; r.k.ferguson@… removed
  • Priority changed from major to critical

comment:16 Changed 12 years ago by jburel

  • Cc mtbcarroll added

This could be related to out of synch currently looked at ​https://github.com/openmicroscopy/openmicroscopy/pull/526

comment:17 Changed 12 years ago by jburel

  • Sprint set to Bugs Fixing

comment:18 Changed 12 years ago by sylittlewood

  • Owner changed from jburel to sylittlewood

comment:19 Changed 12 years ago by mtbcarroll

With my current PR526 changes included, I can still reproduce this bug.

comment:20 Changed 12 years ago by sylittlewood

Speaking with Petr the [New...] option in this instance is invoking the Importer as the user is working from a Dataset context and the next level of the hierarchy is an Image.


We need to nail down exactly what the actual expected behaviour is. As for the exception that has been seen before I have been unable to recreate this locally / with dev_4_4 on howe.

comment:21 Changed 12 years ago by jburel

The error might have happened when browsing HCS data.

comment:22 Changed 12 years ago by jburel

  • Sprint changed from Bugs Fixing to 2013-04-09 (7))

Moved from sprint Bugs Fixing

comment:23 Changed 11 years ago by jburel

  • Sprint changed from 2013-04-09 (7)) to 2013-05-07 (8)

Moved from sprint 2013-04-09 (7))

comment:24 Changed 11 years ago by sylittlewood

  • Owner changed from sylittlewood to jburel

comment:25 Changed 11 years ago by jburel

  • Sprint changed from 2013-05-07 (8) to Blocker 4.4.9 (1)

Moved from sprint 2013-05-07 (8)

comment:26 Changed 11 years ago by jamoore

  • Summary changed from BUG - Insight - right-click menu to BUG: Insight - right-click menu
  • Version set to 4.4.8

Changing to "Bug:" for my query

comment:27 Changed 11 years ago by jburel

  • Resolution set to invalid
  • Status changed from new to closed

Marking this ticket as invalid cf. recent work on menu see ​https://github.com/openmicroscopy/openmicroscopy/pull/1525

Please do re-open if the issue is still there

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.75605 sec.)

© 2000-2014 University of Dundee & Open Microscopy Environment. Creative Commons Attribution 3.0 Unported License
OME source code is available under the GNU General public license or through commercial license from Glencoe Software

We're Hiring!