Task #9802 (closed)
Opened 12 years ago
Closed 10 years ago
BUG: Multiple-selection using Cmd in Insight tree is out of sync with highlighted thumbnails
| Reported by: | spli | Owned by: | jburel |
|---|---|---|---|
| Priority: | minor | Milestone: | Unscheduled |
| Component: | Insight | Version: | 5.0.2 |
| Keywords: | n.a. | Cc: | mtbcarroll |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
- Open a dataset with multiple images. Click on the name of an image in the tree (left pane), the text will be highlighted to indicate it is selected and the corresponding thumbnail will also be highlighted.
- <CMD>-click the name of a different image in the tree to add it to the selection, the name will be correctly highlighted but the corresponding thumbnail won't.
- <CMD>-click the name of a third image in the tree, again the name will be highlighted but the corresponding thumbnail won't, however now the thumbnail from step <2> is highlighted.
There is a constant lag in the thumbnail highlighting.
I think I've tracked this down as far as a mousePressed event attached to the tree: BrowserUI.java:921
which on Linux/Mac? calls onClick(),
handleTreeSelection(),
paths = treeDisplay.getSelectionPaths()
My guess is that at this point treeDisplay hasn't registered the most recently clicked element since the mouse click event hasn't finished, so only returns the items previously selected.
tree.getSelectionPaths() is also called in
BrowserControl.java:337
and again is missing the most recently clicked element.
However this isn't completely reproducible, sometimes onClick() is called a second time at which point treeDisplay has been updated, so the thumbnails are correctly highlighted.
Moving the call to onClick() to
mouseReleased() as for Windows seems to correct this bug, but presumably will break the functionality that required the distinction between Mac/Linux? and Windows in the first place.
Attachments (3)
Change History (8)
Changed 12 years ago by spli
comment:1 Changed 11 years ago by mtbcarroll
Comments on https://github.com/openmicroscopy/openmicroscopy/pull/499 may be relevant: Jean-Marie notices a bug that arises from related aetiology.
comment:2 Changed 11 years ago by mtbcarroll
https://github.com/openmicroscopy/openmicroscopy/pull/510 appears to fix this.
Changed 11 years ago by rkferguson
comment:3 Changed 11 years ago by spli
- Resolution set to fixed
- Status changed from new to closed
It looks like Mark fixed this a while ago.
Changed 11 years ago by spli
comment:4 Changed 11 years ago by spli
- Cc mtbcarroll added
- Resolution fixed deleted
- Status changed from closed to reopened
This has re-appeared again...
- <CMD>-click multiple image names in the tree list, thumbnail highlighting is out of sync.
- Click an image name, hold down <shift> and hit <DOWN-ARROW> to select multiple names usign the keyboard, thumbnail highlighting is again out of sync.
OS X 10.8, Insight.webstart, 4.4.6-1015-46d62c8-ice33-b215
comment:5 Changed 10 years ago by jburel
- Resolution set to fixed
- Status changed from reopened to closed
- Version set to 5.0.2
tested with 5.0.3-rc2. I cannot see the issue. Closing the ticket.
Two items selected in the tree, only one thumbnail highlighted