Task #9896 (closed)
BUG: Add existing user empty menu Insight
| Reported by: | pwalczysko | Owned by: | bpindelski |
|---|---|---|---|
| Priority: | minor | Milestone: | OMERO-4.4.7 |
| Component: | Insight | Version: | n.a. |
| Keywords: | n.a. | Cc: | rkferguson |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | 2012-11-20 (2) |
Description (last modified by pwalczysko)
- Build OMERO.clients-4.4.4-209-76b1091-dirty-ice33-b56.mac from Package folder downloaded on 12-11-12.
- Go to Administration tab.
- (Without previously expanding it) right-click on a group
- Choose Add existing user
- The menu of existing user's is empty
- Cancel, go back to the tree
- Expand the group
- Right-click on the group
- Choose Add existing user
- The users will be in the menu now
When the group is collapsed back again, the Add existing user menu item is still showing the users as it should.
Attachments (2)
Change History (10)
Changed 7 years ago by pwalczysko
Changed 7 years ago by pwalczysko
comment:1 Changed 7 years ago by pwalczysko
- Description modified (diff)
comment:2 Changed 7 years ago by bpindelski
comment:3 Changed 7 years ago by bpindelski
It seems that the asGroup().sizeOfGroupExperimenterMap() >= 0) condition in GroupData.java is the main cause of errors in this issue and #9895. When the getExperimenters() method is called, it returns null and causes either an NPE or the bug mentioned here...
comment:4 Changed 7 years ago by jmoore
sizeOfGroupExperimenterMap < 0 would mean that the items are not loaded, which I guess the insight code is not expecting. If the value is zero, that means there are no experimenters, and so perhaps an empty set would be better. (That would be my expectation)
comment:5 Changed 7 years ago by bpindelski
There is indeed something strange happening here. Will need to consult J-M about Insight code. From what I see, OMEROGateway has a List<ExperimenterData> loadExperimenters(SecurityContext ctx, long groupID) method which definitely returns a list of all OMERO users. I need to see if that has any influence on the value stored in the POJO.
comment:6 Changed 7 years ago by bpindelski
- Owner changed from jburel to bpindelski
comment:7 Changed 7 years ago by bpindelski
- Resolution set to fixed
- Status changed from new to closed
comment:8 Changed 7 years ago by Blazej Pindelski <bpindelski@…>
(In [a993d5ad908a7c544be2f1f5468ab57d5f79865d/ome.git] on branch develop) Fix User Administration in Insight (See #9896)
With Jean-Marie's help #9896 is now fixed. When the admin right-clicks
on the target group for adding users, the dialog is filled in with
elements.
It seems that
Set l = group.getExperimenters();
in TreeViewComponent.java:1737 returns a null if the user/group tree hasn't been expanded. More debugging needed on server side to see why Pojo is not returning a list of users...