Bug: web - Tag name edit from within "Tags" tab causes stacktrace

[khgillen]

In Web in the Tags tab, selecting a tag, and clicking the edit pencil icon button next to the tag name, stacktrace window appears.

FF16 Mac or IE8 WS2003

Traceback (most recent call last):

  File "/home/hudson/hudson/workspace/OMERO-merge-4.4/src/dist/lib/python/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/home/hudson/hudson/workspace/OMERO-merge-4.4/src/dist/lib/python/omeroweb/decorators.py", line 377, in wrapped
    retval = f(request, *args, **kwargs)

  File "/home/hudson/hudson/workspace/OMERO-merge-4.4/src/dist/lib/python/omeroweb/decorators.py", line 414, in wrapper
    context = f(request, *args, **kwargs)

  File "/home/hudson/hudson/workspace/OMERO-merge-4.4/src/dist/lib/python/omeroweb/webclient/views.py", line 1297, in manage_action_containers
    index = int(request.REQUEST.get('index', 0))

ValueError: invalid literal for int() with base 10: ''


<WSGIRequest
GET:<QueryDict: {u'index': [u'']}>,
POST:<QueryDict: {}>,
COOKIES:{'sessionid': '(redacted)'},
META:{'DOCUMENT_ROOT': '/var/www',
 'GATEWAY_INTERFACE': 'CGI/1.1',
 'HTTP_ACCEPT': '*/*',
 'HTTP_ACCEPT_ENCODING': 'gzip, deflate',
 'HTTP_ACCEPT_LANGUAGE': 'en-US,en;q=0.5',
 'HTTP_CONNECTION': 'keep-alive',
 'HTTP_COOKIE': 'sessionid=(redacted)',
 'HTTP_HOST': 'howe.openmircroscopy.org.uk',
 'HTTP_REFERER': 'http://howe.openmicroscopy.org.uk/webclient/usertags/',
 'HTTP_USER_AGENT': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:16.0) Gecko/20100101 Firefox/16.0',
 'HTTP_X_REQUESTED_WITH': 'XMLHttpRequest',
 'PATH': '/usr/local/bin:/usr/bin:/bin',
 'PATH_INFO': u'/webclient/action/editname/tag/4305/',
 'PATH_TRANSLATED': '/var/www/omero.fcgi/webclient/action/editname/tag/4305/',
 'QUERY_STRING': 'index=',
 'REMOTE_ADDR': '(redacted)',
 'REMOTE_PORT': '59007',
 'REQUEST_METHOD': 'GET',
 'REQUEST_URI': '/webclient/action/editname/tag/4305/?index=',
 'SCRIPT_FILENAME': '/var/www/omero.fcgi',
 'SCRIPT_NAME': u'',
 'SERVER_ADDR': '134.36.65.228',
 'SERVER_ADMIN': 'webmaster@localhost',
 'SERVER_NAME': 'howe.openmicroscopy.org.uk',
 'SERVER_PORT': '80',
 'SERVER_PROTOCOL': 'HTTP/1.1',
 'SERVER_SIGNATURE': '<address>Apache/2.2.14 (Ubuntu) Server at howe.openmicroscopy.org.uk Port 80</address>\n',
 'SERVER_SOFTWARE': 'Apache/2.2.14 (Ubuntu)',
 'wsgi.errors': <flup.server.fcgi_base.TeeOutputStream object at 0x7ffad07b5850>,
 'wsgi.input': <flup.server.fcgi_base.InputStream object at 0x7ffad07b5bd0>,
 'wsgi.multiprocess': True,
 'wsgi.multithread': False,
 'wsgi.run_once': False,
 'wsgi.url_scheme': 'http',
 'wsgi.version': (1, 0)}>

[khgillen]

Attempting to "Add a Description" also causes a stacktrace.

[pwalczysko]

Looks like this is fixed.

[wmoore]

​https://github.com/openmicroscopy/openmicroscopy/pull/482

[wmoore]

Reported in ​https://www.openmicroscopy.org/qa2/qa/feedback/4793/

PR will not be merged. Reopening...

[wmoore]

​https://github.com/openmicroscopy/openmicroscopy/pull/482 back in progress again...

[Will Moore <will@…>]

(In [99762e21de6e49f71396f7d885ddcc50addf4833/ome.git] on branch develop) int(request.REQUEST.get('index', 0) all in try/except. See #9918

Can't assume that request strings are castable to int().

[Will Moore <will@…>]

(In [c2dbbac4d4cca7d21bc3039076332fd1da4c8a0c/ome.git] on branch develop) getIntOrDefault(request,name,default) helper. See #9918, PR482

[Will Moore <will@…>]

(In [9ee6f3648798f48c42c9b05c240c09398d9d6947/ome.git] on branch develop) Only add index to editinline urls if {{ index }} in context. See #9918

This is a further measure to prevent invalid ?index= urls to cause errors in parsing request.get('index')