Task #9924 (closed)
Opened 11 years ago
Closed 11 years ago
Bug: Bad wording for adding users to groups
| Reported by: | mtbcarroll | Owned by: | mtbcarroll |
|---|---|---|---|
| Priority: | minor | Milestone: | OMERO-4.4.7 |
| Component: | Insight | Version: | n.a. |
| Keywords: | n.a. | Cc: | ux@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
In Insight when I right-click a group and do "Add Existing ..." the dialogue box claims that I am selecting the users to add to the group. This isn't true: I am selecting the users who should be in the group, not the ones to add; the right box is headed "Selected", which seems to match the "Select" imperative in the sentence. (Indeed, I can even remove users.) Probably this needs to be re-worded: "Select the set of users who should be in the group" or somesuch.
Incidentally, if it were really "select users to add" then doing it in the context of multi-select might actually might sense.
Change History (9)
comment:1 Changed 11 years ago by mtbcarroll
comment:2 Changed 11 years ago by jmoore
- Summary changed from Bad wording for adding users to groups to Bug: Bad wording for adding users to groups
- Type changed from Bug to Task
Changing type to "Task". Mark, due to oddities in the trac/agilo UI, we don't use the Type: Bug, but rather "Tasks" with the summary starting with "Bug:"
comment:3 Changed 11 years ago by jmoore
- Component set to Insight
- Milestone set to OMERO-4.5
- Owner set to jburel
comment:4 Changed 11 years ago by jburel
- Owner changed from jburel to mtbcarroll
comment:5 Changed 11 years ago by mtbcarroll
Further to my final "Incidentally..." paragraph in the description: Should I just change the wording to match the semantics, or may I change the semantics to match the wording and enable it for multi-select? I guess the level of effort depends on to what extent this is going to be ripped out and redone anyway in the coming UI review of this facet.
comment:6 Changed 11 years ago by jburel
I will go for the easiest option i.e. word matching what is currently implemented.
comment:7 Changed 11 years ago by mtbcarroll
- Status changed from new to accepted
comment:8 Changed 11 years ago by mtbcarroll
comment:9 Changed 11 years ago by jmoore
- Resolution set to fixed
- Status changed from accepted to closed
Mark, until we have the other states for tickets (docs/pr/etc) go ahead and close as soon as you open a PR.
Actually, if the semantics were changed to match the wording, then not only could it then make sense for multi-select, but it would fit nicely with allowing multi-select for the "add new user" option too. After all, the present behaviour of limiting adding a new user to being to only one of the multi-selected groups is perhaps needlessly counterintuitive.