Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #9934 (closed)

Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

Bug: IContainer.getImages broken for paging.

Reported by: jamoore Owned by: mtbcarroll
Priority: critical Milestone: OMERO-4.4.9
Component: API Version: 4.4.8
Keywords: n.a. Cc: mtbcarroll, bpindelski, jburel, wmoore, cneves
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: Blocker 4.4.9 (1)

Description

See: https://gist.github.com/4123795/0df607804b88fe40759dec08fa675497831aaca1

For all pages after the first, the following returns nothing:

                    ParametersI param2 = new ParametersI();
                    param2.page(0, batchSize);
                    int whichPage = 1;

                    List<Long> dsIds = new ArrayList<Long>();
                    dsIds.add(vDataSetId);
                    while (true) {

                        List<Image> images = proxy.getImages(Dataset.class.getName(), dsIds, param2);

Change History (10)

comment:1 Changed 8 years ago by mtbcarroll

  • Owner changed from jamoore to mtbcarroll
  • Version set to 4.4.8

comment:2 Changed 8 years ago by mtbcarroll

  • Status changed from new to accepted

comment:3 Changed 8 years ago by mtbcarroll

  • Sprint set to Blocker 4.4.9 (1)

comment:4 Changed 8 years ago by mtbcarroll

This gist code seems to be working fine for me: I can retrieve the right number of images spread across multiple pages, whether on howe or gretzky, and if they are the owned by the logged-in user or not. Could you be clearer about how to see this bug? But, the quoted code doesn't quite match the gist: is there some older revision of it that is good code that is wrongly not working?

comment:5 Changed 8 years ago by mtbcarroll

The specific revision linked to is the one that should work but doesn't. (Ignore later revisions.)

comment:6 Changed 8 years ago by mtbcarroll

  • Remaining Time changed from 0.25 to 0
  • Resolution set to fixed
  • Status changed from accepted to closed

comment:7 Changed 8 years ago by Mark Carroll <m.t.b.carroll@…>

(In [51c7b7da53bf299d848199f07185c4e51a4c4250/ome.git] on branch develop) fix #9934: adjust query options once pagination is done

comment:8 Changed 8 years ago by Josh Moore <josh@…>

(In [c50dafbaee3d0edbeb613c63a1b324d974a0e108/ome.git] on branch develop) Merge pull request #1495 from mtbc/query-paging-9934-dev

fix #9934: adjust query options once pagination is done (rebased)

comment:9 Changed 8 years ago by Mark Carroll <m.t.b.carroll@…>

(In [0e22e19126574d8bc88e1611a9be2779f901f80c/ome.git]on branches master, dev_4_4) fix #9934: adjust query options once pagination is done

comment:10 Changed 8 years ago by Josh Moore <josh@…>

(In [97eb38d597977c6f92f2e024eef6ae2afc7d1b1d/ome.git]on branches master, dev_4_4) Merge pull request #1456 from mtbc/query-paging-9934

fix #9934: adjust query options once pagination is done

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.68456 sec.)

We're Hiring!