Task #10824 (closed)
Opened 11 years ago
Closed 9 years ago
RFE: NetworkChecker modifications
Reported by: | jamoore | Owned by: | sebastien.simard@… |
---|---|---|---|
Priority: | critical | Milestone: | 5.x |
Component: | Insight | Version: | 5.0.8 |
Keywords: | n.a. | Cc: | jburel, cxallan, mtbcarroll, bpindelski, sylittlewood |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description (last modified by jamoore)
See:
- https://github.com/openmicroscopy/openmicroscopy/issues/821 (J-M)
- https://github.com/openmicroscopy/openmicroscopy/pull/1070 (Zeb) (and https://www.openmicroscopy.org/community/viewtopic.php?f=4&t=4509)
- https://github.com/openmicroscopy/openmicroscopy/pull/1075 (J-M)
- https://github.com/openmicroscopy/openmicroscopy/pull/1128 (Josh)
Now that isNetworkUp() is called on every remote invocation reducing blockages will become paramount.
Suggested improvements from a discussion with Chris Allan:
- Move from testing openmicroscopy.org.uk to testing the server/port that Ice is configured to use. This may require housing the NetworkChecker inside of the SecurityContext, though on shutdown it's unclear which one should be used.
- Set timeouts on all sockets. If using URL, set via URLConnection#setReadTimeout
Further improvements which could also be considered (perhaps as a second ticket):
- Check uses of getHostAddress for hanging (see https://github.com/openmicroscopy/openmicroscopy/pull/1075/files#L3R2384)
Consider a reflection-based method which would use the improved Java 6 APIs if available.(Done in PR 1128)- Refactor NetworkChecker? to include logging.
Change History (10)
comment:1 Changed 11 years ago by jamoore
comment:2 Changed 11 years ago by jburel
Unfortunately it has to be made on every method call at the moment
Any Java 6 feature cannot be considered on 4.4.x since the minimum required is 1.5
comment:3 Changed 11 years ago by jamoore
- Description modified (diff)
comment:4 Changed 11 years ago by jburel
Move from testing openmicroscopy.org.uk to testing the server/port that Ice is configured to use. This may require housing the NetworkChecker inside of the SecurityContext, though on shutdown it's unclear which one should be used.
That was the initial idea, but I did not have a chance to refactor the code. Note that the check only happens on linux due to again a limitation of Java 1.5
- First thing to do will be to re-activate the Java 1.6 or higher code on develop to see.
comment:5 Changed 11 years ago by jamoore
- Description modified (diff)
comment:6 Changed 11 years ago by jamoore
- Description modified (diff)
comment:7 Changed 11 years ago by Melissa Linkert <melissa@…>
(In [005f8f6284402083558aa636495dd87f563154d4/ome.git] on branch develop) Use the reflected network check on non-Linux platforms
If it has been determined that the reflected check (i.e. using Java 1.6+
code) can be used, then try that first on non-Linux systems. If it
returns false or cannot be run, then the original Java 1.5 is still
used.
This prevents the network from being detected as down on non-Linux
systems with Java 1.7.0-b27.
comment:8 Changed 10 years ago by jburel
The change made by the previous commit does not work i.e. return value is true. This explains the error reported .
comment:9 Changed 10 years ago by jamoore
This closeable with https://github.com/openmicroscopy/openmicroscopy/pull/1977 ?
comment:10 Changed 9 years ago by jburel
- Resolution set to fixed
- Status changed from new to closed
- Version set to 5.0.8
This ticket can be closed.
Please re-open if required.
See: https://www.openmicroscopy.org/qa2/qa/feedback/6622