BUG: Web - STEP ERR - trying to move image between groups without selecting dataset as destination

[rkferguson]

Testing with Web client on gretzky 5.0.0-alpha4-436-879a315-dirty-ice33-b308 user-2 private-1 and read-only-1

Was testing ability to move image from read-only-1 to private-1 group which had only datasets in it.

Dialogue appeared correctly and was able to successfully move to the 2 datasets there.

When tried moving image without selecting one of the 2 datasets - expecting it to go to orphaned - Activity menu reported:

"Move to Group 'private-1'
STEP ERR step: 0, stack trace:"

When checking, images are successfully moved into the dataset, but image moved without selecting a dataset disappeared from original group but does not appear in Orphaned. On refresh image reappears in original group.

Repeated with same result.

Error comes ups as:

STEP ERR step: 0, stacktrace: ome.services.graphs.GraphConstraintException(message=DatasetImageLink:164 improperly links to 1 objects
at ome.services.chgrp.ChgrpStep.validate(ChgrpStep.java:163)
at omero.cmd.graphs.ChgrpI.finish(ChgrpI.java:188)
at omero.cmd.basic.DoAllI.finish(DoAllI.java:330)
at omero.cmd.HandleI.steps(HandleI.java:466)
at omero.cmd.HandleI$1.doWork(HandleI.java:365)
at omero.cmd.HandleI$1.doWork(HandleI.java:361)
at sun.reflect.GeneratedMethodAccessor265.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:307)
at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
at ome.services.util.Executor$Impl$Interceptor.invoke(Executor.java:576)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
at ome.security.basic.EventHandler.invoke(EventHandler.java:154)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
at org.springframework.orm.hibernate3.HibernateInterceptor.invoke(HibernateInterceptor.java:111)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:108)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
at ome.tools.hibernate.ProxyCleanupFilter$Interceptor.invoke(ProxyCleanupFilter.java:241)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
at ome.services.util.ServiceHandler.invoke(ServiceHandler.java:116)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202)
at $Proxy66.doWork(Unknown Source)
at ome.services.util.Executor$Impl.execute(Executor.java:457)
at omero.cmd.HandleI.run(HandleI.java:359)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at ome.services.util.Executor$Impl$1.call(Executor.java:498)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:619)
, message: , GraphConstraintException: true, id: 22

[jamoore]

• Import 11118.fake as user-2 into private-1
• move to read-only-1 (DS: TEST2)
• move back to private-1 (no DS)
• ome.services.graphs.GraphConstraintException(message=DatasetImageLink:181 improperly links to 1 objects
• refresh
• move back to private-1 (DS: "Test images small - ten") success bizarre

[jamoore]

PR filed: ​https://github.com/openmicroscopy/openmicroscopy/pull/1288

[jmoore <josh@…>]

(In [303561b2e4b50d009fc88850ad3d42e3bffd4556/ome.git] on branch develop) Failing chgrp test (See #11118)

[jmoore <josh@…>]

(In [724f866198bb6f7b099a716b6c07263829a4e3cc/ome.git] on branch develop) Refactor ChgrpStep?.validate() to GraphStep? (Fix #11109, #11118)

The opts available to ChgrpStep?.validate were invalid since
GraphState? was not maintaining a stack of opts as it descended
the tree, therefore FORCE was not being properly passed to the
likes of DatasetImageLink? et al.

Now all GraphSteps? have the opportunity to take part in graph
validation, though it may take some work to make Deletion (not
itself a Step) behave properly.