Context Navigation

← Previous Ticket
Next Ticket →

Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.

Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #2282 (assigned)

Opened 14 years ago

Last modified 10 years ago

Delete bad scripts on upload/copy

Reported by:	jamoore	Owned by:	jamoore
Priority:	major	Milestone:	Unscheduled
Component:	Scripting	Version:	n.a.
Keywords:	n.a.	Cc:	wmoore, jburel
Resources:	n.a.	Referenced By:	n.a.
References:	n.a.	Remaining Time:	0.5d
Sprint:	n.a.

Description

If uploadScript throws an exception or if the script found in lib/scripts, then the file should be deleted (from the db and fs)

References

Referenced by:
← User Story (#1860): Scripts Cleanup ← User Story (#1341): Scripting improvements : api, cli, parse

Change History (14)

comment:1 Changed 14 years ago by jmoore

Status changed from new to assigned

comment:2 Changed 14 years ago by wmoore

(In [6842]) Test for validation. Test fails if invalid script upload / edit does not throw exception. See #2282.

comment:3 Changed 14 years ago by jmoore

 - deleting invalid scripts (#2282)
  -- ok for now.
  -- may get bug reports

comment:4 Changed 14 years ago by jmoore

(In [6935]) see #2282 - Disabling scripts via mimetype on ValidationException

comment:5 Changed 14 years ago by jmoore

(In [6939]) see #2282 - Refactoring RepoFile for cleaner usage

Previously, addOrReplace was causing edited scripts to create
a new original file, so that on subsequent executions with the
original ID, a script that was assumed modified (and in the test
invalid) had actually not been modified.

comment:6 Changed 14 years ago by jmoore

Leaving open for testing.

comment:7 Changed 14 years ago by wmoore

(In [6955]) Updated test to check invalid scripts are not returned by getScripts() etc. See #2282

comment:8 Changed 14 years ago by jmoore

Sprint changed from 2010-04-30 (8) to 2010-05-13 (9)

comment:9 Changed 14 years ago by jmoore

(In [6957]) see #2282 - Fixing return of invalid scripts with text/plain

comment:10 Changed 14 years ago by jmoore

(In [6978]) see #2282 - Fixing test

comment:11 Changed 14 years ago by cxallan

Sprint changed from 2010-05-13 (9) to 2010-05-27 (10)

comment:12 Changed 14 years ago by cxallan

Sprint changed from 2010-05-27 (10) to 2010-06-10 (11)

comment:13 Changed 14 years ago by jmoore

Milestone changed from OMERO-Beta4.2 to Unscheduled
Sprint 2010-06-10 (11) deleted

This will need further evaluation. We'll wait to get some feedback from 4.2.0 first, though.

comment:14 Changed 10 years ago by jamoore

Referencing ticket #1341 has changed sprint.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

Download in other formats: