Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #3655 (closed)

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

Broken functionality in omero.gateway

Reported by: wmoore Owned by: cneves
Priority: major Milestone: OMERO-Beta4.3
Component: OmeroPy Version: n.a.
Keywords: n.a. Cc: cneves, atarkowska, jamoore
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2011-01-27 (4)

Description (last modified by wmoore)

Appears that some functions are broken - Items in first comment discussed with Carlos 10th Jan'10

Will to fix all except where ticket created:

  • _BlitzGateway.seppuku (self, softclose=False) softclose ignored. TODO: remove softclose. See webgateway/views.py: c.seppuku(softclose=True)
  • _BlitzGateway._createSession (self, skipSUuid=False) skipSUuid ignored. TODO: remove skipSUuid - DONE
  • _BlitzGateway.isOwner (self, gid=None) throws exception if gid=None. TODO: fix if None: DONE
  • getColleaguesAndStaffs() - leaderOfGroups must be a subset of memberOfGroups? #3649
  • getSpecifiedPlates(self, oids) returns DatasetWrapper #3805
  • def deleteAnnotation(self, oid, child=None, anns=None) child and anns ignored. #3803
  • some delete methods use id and some use obj (only ID is needed). Should all use ID? #3803
  • _LightPathWrapper.copyEmissionFilters(self) and copyExcitationFilters both 'pass' TODO: should 'raise NotImplementedError?' #3852
  • ImageWrapper.renderJpeg (self, z, t, compression=0.9) z should be optional for projections? TODO: Docs to say use z=0. DONE
  • ImageWrapper.createMovie() import createMovie is commented out - method won't work? #3800
  • prepareLinePlotCanvas (self, z, t) z and t ignored. TODO: remove these. DONE

Change History (31)

comment:1 Changed 13 years ago by wmoore

  • _BlitzGateway.seppuku (self, softclose=False) softclose ignored.
  • _BlitzGateway._createSession (self, skipSUuid=False) skipSUuid ignored.
  • _BlitzGateway.isOwner (self, gid=None) throws exception if gid=None.
  • getColleaguesAndStaffs() - leaderOfGroups must be a subset of memberOfGroups?
  • getSpecifiedPlates(self, oids) returns DatasetWrapper
  • def deleteAnnotation(self, oid, child=None, anns=None) child and anns ignored.
  • some delete methods use id and some use obj (only ID is needed). Should all use ID?
  • _LightPathWrapper.copyEmissionFilters(self) and copyExcitationFilters both 'pass'
  • ImageWrapper.renderJpeg (self, z, t, compression=0.9) z should be optional for projections?
  • ImageWrapper.createMovie() import createMovie is commented out - method won't work?
  • prepareLinePlotCanvas (self, z, t) z and t ignored.

comment:2 Changed 13 years ago by jmoore

  • Cc jmoore added

comment:3 Changed 13 years ago by wmoore

  • Status changed from new to assigned

comment:4 Changed 13 years ago by wmoore

  • Owner changed from wmoore to cneves-x
  • Status changed from assigned to new

comment:5 Changed 13 years ago by wmoore

(In [8741]) Editing some doc comments in omero.gateway. See #3655, #3656

comment:6 Changed 13 years ago by jburel

  • Sprint changed from 2010-12-09 (21) to 2010-12-23 (22)

Moved from sprint 2010-12-09 (21)

comment:7 Changed 13 years ago by jburel

  • Sprint changed from 2010-12-23 (22) to 2011-01-13 (23)

Moved from sprint 2010-12-23 (22)

comment:8 Changed 13 years ago by wmoore

(In [8769/omero]) Fixing bug in gateway setGroupForSession(). See #3655

comment:9 Changed 13 years ago by wmoore

  • Description modified (diff)

comment:10 Changed 13 years ago by wmoore

  • Owner changed from cneves-x to wmoore

comment:11 Changed 13 years ago by wmoore

  • Status changed from new to accepted

comment:12 Changed 13 years ago by wmoore

  • Description modified (diff)

comment:13 Changed 13 years ago by wmoore

(In [8889/omero]) Fix all issues in gateway #3655 except seppuku(). See #3655.

comment:14 Changed 13 years ago by wmoore

(In [8892/omero]) Fix bug in my last commit of gateway. See #3655

comment:15 Changed 13 years ago by jburel

  • Sprint changed from 2011-01-13 (23) to 2011-01-27 (24)

Moved from sprint 2011-01-13 (23)

comment:16 Changed 13 years ago by wmoore

  • Remaining Time set to 0
  • Resolution set to fixed
  • Status changed from accepted to closed

(In [8904/omero]) Fixing last issue: c.seppuku(softclose=True) which closes #3655

comment:17 Changed 13 years ago by cneves

  • Remaining Time changed from 0 to 0.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

softclose does in fact play a role, although that was broken in the current implementation. Django processors hold a dictionary of connections, key is a browser cookie, to prevent having to open a connection per call.
When the size of this dictionary reaches a certain size (currently 70), it gets purged by removing the oldest 25%.

This removal calls seppuku(softclose=True) to close the connection but only close the session if it is not referenced elsewhere. Right now users are being logged out from omero if their connections are purged.

I'm reopening the ticket and will make softclose to re-implement softclose.

comment:18 Changed 13 years ago by cneves

  • Owner changed from wmoore to cneves-x
  • Status changed from reopened to new

comment:19 Changed 13 years ago by wmoore

  • Description modified (diff)

comment:20 Changed 13 years ago by wmoore

(In [8926/omero]) Adding back c.seppuku(softclose=True) to webgateway.views.py. See #3655

comment:21 Changed 13 years ago by wmoore

  • Remaining Time changed from 0.2 to 0
  • Resolution set to fixed
  • Status changed from new to closed

The last issue from this ticket has been moved to #3930

comment:22 Changed 13 years ago by Carlos Neves <carlos@…>

(In [d26fbf9dcc85cccd73fd38b8dfb8c2ba388e28b0/ome.git] on branch dev_4_1_custom) Fix all issues in gateway #3655 except seppuku(). See #3655.

git-svn-id: ​file:///home/svn/omero/trunk@8889 05709c45-44f0-0310-885b-81a1db45b4a6

comment:23 Changed 13 years ago by Carlos Neves <carlos@…>

(In [7566a186521fc1b208538323b6c14a1677b516dc/ome.git] on branch dev_4_1_custom) Fix bug in my last commit of gateway. See #3655

git-svn-id: ​file:///home/svn/omero/trunk@8892 05709c45-44f0-0310-885b-81a1db45b4a6

comment:24 Changed 13 years ago by Carlos Neves <carlos@…>

(In [2cbb0371d1aa0225a7ebd5e3bd89c03b04b3f52c/ome.git] on branch dev_4_1_custom) Fixing last issue: c.seppuku(softclose=True) which closes #3655

git-svn-id: ​file:///home/svn/omero/trunk@8904 05709c45-44f0-0310-885b-81a1db45b4a6

comment:25 Changed 13 years ago by Carlos Neves <carlos@…>

(In [cef541cf8a416944b7b3e9d6943a3832217e58a7/ome.git] on branch dev_4_1_custom) Fixing last issue: c.seppuku(softclose=True) which closes #3655

git-svn-id: ​file:///home/svn/omero/trunk@8904 05709c45-44f0-0310-885b-81a1db45b4a6

comment:26 Changed 13 years ago by Carlos Neves <carlos@…>

(In [269ae017bb5cfcd1bc810af9891f7ee58f5c6510/ome.git] on branch dev_4_1_custom) Adding back c.seppuku(softclose=True) to webgateway.views.py. See #3655

git-svn-id: ​file:///home/svn/omero/trunk@8926 05709c45-44f0-0310-885b-81a1db45b4a6

comment:27 Changed 13 years ago by Carlos Neves <carlos@…>

(In [d26fbf9dcc85cccd73fd38b8dfb8c2ba388e28b0/ome.git]on branches 4_1_custom, dev_4_1_custom, josh/4.1-web-backport) Fix all issues in gateway #3655 except seppuku(). See #3655.

git-svn-id: ​file:///home/svn/omero/trunk@8889 05709c45-44f0-0310-885b-81a1db45b4a6

comment:28 Changed 13 years ago by Carlos Neves <carlos@…>

(In [7566a186521fc1b208538323b6c14a1677b516dc/ome.git]on branches 4_1_custom, dev_4_1_custom, josh/4.1-web-backport) Fix bug in my last commit of gateway. See #3655

git-svn-id: ​file:///home/svn/omero/trunk@8892 05709c45-44f0-0310-885b-81a1db45b4a6

comment:29 Changed 13 years ago by Carlos Neves <carlos@…>

(In [2cbb0371d1aa0225a7ebd5e3bd89c03b04b3f52c/ome.git]on branches 4_1_custom, dev_4_1_custom, josh/4.1-web-backport) Fixing last issue: c.seppuku(softclose=True) which closes #3655

git-svn-id: ​file:///home/svn/omero/trunk@8904 05709c45-44f0-0310-885b-81a1db45b4a6

comment:30 Changed 13 years ago by Carlos Neves <carlos@…>

(In [cef541cf8a416944b7b3e9d6943a3832217e58a7/ome.git]on branches 4_1_custom, dev_4_1_custom, josh/4.1-web-backport) Fixing last issue: c.seppuku(softclose=True) which closes #3655

git-svn-id: ​file:///home/svn/omero/trunk@8904 05709c45-44f0-0310-885b-81a1db45b4a6

comment:31 Changed 13 years ago by Carlos Neves <carlos@…>

(In [269ae017bb5cfcd1bc810af9891f7ee58f5c6510/ome.git]on branches 4_1_custom, dev_4_1_custom, josh/4.1-web-backport) Adding back c.seppuku(softclose=True) to webgateway.views.py. See #3655

git-svn-id: ​file:///home/svn/omero/trunk@8926 05709c45-44f0-0310-885b-81a1db45b4a6

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.75363 sec.)

© 2000-2014 University of Dundee & Open Microscopy Environment. Creative Commons Attribution 3.0 Unported License
OME source code is available under the GNU General public license or through commercial license from Glencoe Software

We're Hiring!