Task #4183 (closed)
Opened 13 years ago
Closed 13 years ago
Make sure that static fields are being used properly
Reported by: | mlinkert | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | OMERO-Beta4.3 |
Component: | Bio-Formats | Version: | n.a. |
Keywords: | n.a. | Cc: | jamoore |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | 0.0d |
Sprint: | 2011-02-24 (6) |
Description (last modified by mlinkert)
There are several static (non-final) HashMaps/Hashtables? throughout the reader classes that could be made final.
The 'uuids' field in OMETiffWriter is static, but it is never cleared. If possible, it would be best to make this field non-static, or at least provide a mechanism for clearing stale entries to prevent memory leaks.
Similarly, the Location has several static fields (including 'idMap' and 'fileListings') for which it would be nice to have a master reset method that clears the HashMaps/Hashtables? and resets associated fields to their original state.
Finally, we need to ensure that static fields are accessed in a thread-safe manner.
Change History (9)
comment:1 Changed 13 years ago by jmoore
comment:2 Changed 13 years ago by mlinkert
- Description modified (diff)
- Keywords sprint-1 removed
- Remaining Time set to 0.5
- Sprint set to 2011-02-10 (5)
comment:3 Changed 13 years ago by mlinkert
- Status changed from new to accepted
comment:4 Changed 13 years ago by mlinkert
- Remaining Time changed from 0.5 to 0.25
comment:5 Changed 13 years ago by Melissa Linkert <melissa@…>
(In [df9e3eb53c1f9d7b4bd94089a6c88ae3a8169fe0/bioformats.git]) Changed several private static variables to be final. See #4183.
comment:6 Changed 13 years ago by Melissa Linkert <melissa@…>
(In [df9e3eb53c1f9d7b4bd94089a6c88ae3a8169fe0/bioformats.git]) Changed several private static variables to be final. See #4183.
comment:7 Changed 13 years ago by jburel
- Sprint changed from 2011-02-10 (5) to 2011-02-24 (6)
Moved from sprint 2011-02-10 (5)
comment:8 Changed 13 years ago by mlinkert
- Owner mlinkert-x deleted
- Status changed from accepted to new
comment:9 Changed 13 years ago by mlinkert
- Remaining Time changed from 0.25 to 0
- Resolution set to fixed
- Status changed from new to closed
Resolved with [80716c7d25d36177c35133babfe3f4f09d41009f/bioformats.git].
imported from bio-formats:#639