Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #10849 (closed)

Opened 11 years ago

Closed 11 years ago

Log file id and event

Reported by: jburel Owned by: cblackburn
Priority: blocker Milestone: 5.0.0-beta1
Component: General Version: n.a.
Keywords: FS Cc: fs@…
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: FS Demo 4.3

Description

As soon as the log file is created, an event with the id of the file should be posted to notify the client.
Currently no notification in place, so the client waits for the import to be completed to request the log file linked to the image. This implies that the image was returned, which might not be the case if an error occurred.
This also implies that a large number of calls has to be made in order to retrieve a log file per image.

Change History (13)

comment:1 Changed 11 years ago by jburel

  • Keywords FS added

comment:2 Changed 11 years ago by jburel

  • Sprint changed from FS demo 4.x to FS demo 4.2

comment:3 Changed 11 years ago by cblackburn

This change isn't trivial and so may not be suitable for FS demo 4.2. The import log registration (when the OriginalFile id is first known) takes place on the repo side. Notifications from here are not yet passed back to the client. If they were then a trivial solution, importlog-notification could be used. However, the whole issue of notifications needs to be addressed possibly as part of import workflow refactoring, which would also allow more information to be logged in the first place. In the shorter term, it might be possible to somehow obtain the Fileset or OriginalFile ids elsewhere within the workflow - for notification and improved log information - but this would need to be investigated.

comment:4 Changed 11 years ago by jburel

import refactoring is scheduled for demo 4.2. Finishing mockup with Gus then ready to go.

comment:5 Changed 11 years ago by cblackburn

  • Status changed from new to accepted

comment:6 Changed 11 years ago by cblackburn

It isn't easily possible to notify as soon as the log file is created with the current workflow but this branch adds the Fileset ID to the notifications. This still means if the import fails very early there may be no access to the log even if it has been created, but it does mean the ID is available to the client.

The whole of the logging and notification system for FS needs reworking but that falls outwith this ticket.

comment:7 Changed 11 years ago by jamoore

Colin: is this something I should take into account with the import-set-api branch? I.e. do we need a getter for the original file and we go ahead and create it even if some other phase of the import fails?

comment:8 Changed 11 years ago by cblackburn

Josh: I think we need to need to have the log file available as early as possible and that might mean doing something like you suggest. But at the moment I'm not sure how useful the information in the log file actually is. So having the OriginalFile id or Fileset id available to Insight is good for demos but we definitely need to look at revising the logging process.

comment:9 Changed 11 years ago by jburel

I have modified the code. I will have the filesetID when the upload is complete, I will do with that for the first round.

comment:10 Changed 11 years ago by cblackburn

Jean-Marie: do you want me to open a PR or will you just cherry-pick the commit from my branch?

comment:11 Changed 11 years ago by jburel

I could cherry-pick but I will need to check who is listening for that event first to see what I can do with it.

comment:12 Changed 11 years ago by jburel

  • Sprint changed from FS demo 4.2 to FS Demo 4.3

Moved from sprint FS demo 4.2

comment:13 Changed 11 years ago by jburel

  • Resolution set to fixed
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.76287 sec.)

We're Hiring!