Task #11864 (closed)
Opened 10 years ago
Closed 10 years ago
IJ slf4j logging issue
Reported by: | jamoore | Owned by: | cblackburn |
---|---|---|---|
Priority: | major | Milestone: | 5.0.0 |
Component: | General | Version: | 5.0.0-rc1 |
Keywords: | n.a. | Cc: | jburel, mlinkert, rleigh, cblackburn |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description
Running 5.0.0-rc1 with Imagej1.47:
jamoore@blue:/tmp/BF/ij/ImageJ$ sh run SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/tmp/BF/ij/ImageJ/plugins/OMERO.insight-ij-5.0.0-rc1-ice33-b10/libs/slf4j-log4j12.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/tmp/BF/ij/ImageJ/plugins/loci_tools.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
Change History (8)
comment:1 Changed 10 years ago by bpindelski
- Owner set to bpindelski
comment:2 Changed 10 years ago by jamoore
- Owner changed from bpindelski to mlinkert
comment:3 Changed 10 years ago by bpindelski
I've assigned the ticket to me to verity that it still happens and see if there is a quick solution to this issue. If the problem is more complex than I anticipate it to be, then it can definitely be pushed to 5.1 or 5.0.1.
comment:4 Changed 10 years ago by jamoore
- Owner changed from mlinkert to bpindelski
Sorry, Blazej. My edit overwrote yours. Fixing.
comment:5 Changed 10 years ago by bpindelski
This still happens with http://ci.openmicroscopy.org/job/OMERO-5.0-merge-daily/lastSuccessfulBuild/artifact/src/target/OMERO.insight-ij-5.0.0-rc1-207-36220ac-ice33-b556.zip and the latest loci_tools.jar. The OMERO-insight-ij.zip file contains a libs directory, which in turn contains the slf4j-log4j.jar file - this file in turn causes the "multiple bindings" warning. One way of solving this would be to conditionally exclude the log4j binding on creation of the zip file.
comment:6 Changed 10 years ago by jamoore
- Cc cblackburn added
Perhaps that means that on cblackburn's current SLF4J branch this won't happen?
comment:7 Changed 10 years ago by bpindelski
- Owner changed from bpindelski to cblackburn
Assigning to Colin for further review.
comment:8 Changed 10 years ago by sbesson
- Resolution set to fixed
- Status changed from new to closed
See https://github.com/openmicroscopy/openmicroscopy/pull/2043 and https://github.com/openmicroscopy/bioformats/pull/880
ome_tools.jar now contains as much as loci_tools.jar except slfj4-log4j and log4j and should be the JAR to associate with the OMERO.insight-ij plugin
Is this something we can try to resolve for 5.0.0? Or does it need to be pushed?