Task #11946 (closed)
Opened 10 years ago
Closed 10 years ago
BUG: Rendering Full Viewer
| Reported by: | pwalczysko | Owned by: | jburel |
|---|---|---|---|
| Priority: | major | Milestone: | 5.0.0 |
| Component: | Insight | Version: | 5.0.0-beta2-RC3 |
| Keywords: | n.a. | Cc: | ux@…, |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
During a re-test of (already merged) https://github.com/openmicroscopy/openmicroscopy/pull/1992 hit a bug.
Server: trout, user-1, Dataset:dv,
Prescribed tests (see also https://github.com/openmicroscopy/openmicroscopy/pull/2004):
To Test:
- Import twice the same image
- Open one image in Full Viewer.
- Turn off one channel for example. Save. and keep the viewer opened
- Go to the data manager.
- Select the image not opened. Right-click and select Rendering Settings >Copy rnd
- Select in the data manager, the image opened. Right-click and select Rendering Settings/ Paste rnd.
- Thumbnail should be updated, image in the viewer should be updated.
- Close the viewer. The save dialog should not be displayed.
Second test
However when the first image (the one that was modified and then had settings from second image pasted into it) is subsequently modified and the changes saved, it should not just revert to the pasted settings every time.
This second test failed for me here. After
- I have changed the image rendering settings subsequently in the opened image,
- closed the full viewer, and to the popup answered Yes to save my changes
- the thumbnail did not update to the rendering settings which I have changed the last time
- re-opened the image and see that there is a discrepancy between thumb and full viewer now (see screenshot)
Putting into 5.0.0 as discussed with @jburel
Attachments (1)
Change History (6)
Changed 10 years ago by pwalczysko
comment:1 Changed 10 years ago by jburel
comment:2 Changed 10 years ago by jburel
I have a tmp solution in insight but does not solve the underline problem. This is a corner, I will push unless I have time to fix it today
comment:3 Changed 10 years ago by jburel
After some debugging, figure out that the sequence is key:
- Open one image
- Copy settings from second and paste them to first image. The update_id of the rdef is updated.
- Modify in viewer the rdef e.g. turn off one channel. Hit SAVE. The update_id of the rdef is NOT updated.
If you only modify the rdef in the viewer and hit SAVE. The update_id of the rdef is updated.
comment:4 Changed 10 years ago by jburel
The same problem happens if you do the following
- Open an image.
- go to data manager, and click reset default
- The thumbnail is updated and the rdef saved
- Modify in viewer the rdef e.g. turn off one channel. Hit SAVE. The update_id of the rdef is NOT updated.
comment:5 Changed 10 years ago by jburel
- Resolution set to fixed
- Status changed from new to closed
investigating the issue, it looks like the problem is in the thumbnail bean.