Task #12904 (closed)
Opened 4 years ago
Closed 4 years ago
RFE: Chmod2 could be faster for not-to-private
| Reported by: | mtbcarroll | Owned by: | mtbcarroll |
|---|---|---|---|
| Priority: | major | Milestone: | 5.1.3 |
| Component: | Services | Version: | 5.1.1 |
| Keywords: | n.a. | Cc: | server@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
#12902 describes a LockTimeout for "upgrade this private group to read-only-1". Having BaseGraphPolicyAdjuster.isBlockedFromAdjustment always return true may not suffice to shortcut graph traversal for permissions upgrades. Perhaps even more processing can be easily skipped.
Change History (7)
comment:1 Changed 4 years ago by jamoore
comment:2 Changed 4 years ago by mtbcarroll
The confirmation is good. We are doing a bunch of GraphTraversal.findObjectDetails for objects that we certainly won't be operating on.
comment:3 Changed 4 years ago by mtbcarroll
- Milestone changed from 5.x to 5.1.4
- Priority changed from minor to major
comment:4 Changed 4 years ago by mtbcarroll
- Owner set to mtbcarroll
comment:5 Changed 4 years ago by mtbcarroll
comment:6 Changed 4 years ago by mtbcarroll
- Milestone changed from 5.1.4 to 5.1.3
comment:7 Changed 4 years ago by mtbcarroll
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
Some more info from testing https://github.com/openmicroscopy/openmicroscopy/pull/3853
Checking jstack on 504 Gateway Time-out:
"pool-2-thread-2" prio=10 tid=0x00007f706c004800 nid=0x461a runnable [0x00007f70dfffd000] java.lang.Thread.State: RUNNABLE at java.net.SocketOutputStream.socketWrite0(Native Method) at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:113) at java.net.SocketOutputStream.write(SocketOutputStream.java:159) at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82) at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140) - locked <0x000000064d52f688> (a java.io.BufferedOutputStream) at org.postgresql.core.PGStream.flush(PGStream.java:531) at org.postgresql.core.v3.QueryExecutorImpl.sendSync(QueryExecutorImpl.java:1244) at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:254) - locked <0x000000064d52f850> (a org.postgresql.core.v3.QueryExecutorImpl) at org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:570) at org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:420) at org.postgresql.jdbc2.AbstractJdbc2Statement.executeQuery(AbstractJdbc2Statement.java:305) at sun.reflect.GeneratedMethodAccessor47.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at bitronix.tm.resource.jdbc.BaseProxyHandlerClass.invoke(BaseProxyHa ... at org.hibernate.loader.Loader.getResultSet(Loader.java:1869) at org.hibernate.loader.hql.QueryLoader.iterate(QueryLoader.java:476) at org.hibernate.hql.ast.QueryTranslatorImpl.iterate(QueryTranslatorImpl.java:405) at org.hibernate.engine.query.HQLQueryPlan.performIterate(HQLQueryPlan.java:248) at org.hibernate.impl.SessionImpl.iterate(SessionImpl.java:1331) at org.hibernate.impl.QueryImpl.iterate(QueryImpl.java:69) at ome.services.graphs.GraphTraversal.findObjectDetails(GraphTraversal.java:696) at ome.services.graphs.GraphTraversal.getLinksToCache(GraphTraversal.java:819) at ome.services.graphs.GraphTraversal.cache(GraphTraversal.java:878) at ome.services.graphs.GraphTraversal.planOperation(GraphTraversal.java:560) at ome.services.graphs.GraphTraversal.planOperation(GraphTraversal.java:476) at omero.cmd.graphs.Chmod2I.step(Chmod2I.java:217)Won't paste much more since I assume Mark already knows what the issue is.