Bug: ScreenLogin.logout throws when communicator is destroyed

[jamoore]

        try {
            // Save login screen groups
            ScreenLogin.registerGroup(getLoginHandler().getMetadataStore().mapUserGroups());
        } catch (Exception e) {
            log.warn("Exception on ScreenLogin.registerGroup()", e);
        }

cannot succeed on a session timeout or similar:

Caused by: Ice.ObjectNotExistException^M
    id.name = "838fa6dc-26f0-45d5-a890-8c8b18f5ffb7"^M
    id.category = "session-88118a68-c798-4e4a-9864-1e06e32a69f3"^M
    facet = ""^M
    operation = "keepAllAlive"^M
        at IceInternal.Outgoing.invoke(Outgoing.java:147)^M
        at omero.api._ServiceFactoryDelM.keepAllAlive(_ServiceFactoryDelM.java:1579)^M
        at omero.api.ServiceFactoryPrxHelper.keepAllAlive(ServiceFactoryPrxHelper.java:1648)^M
        at omero.api.ServiceFactoryPrxHelper.keepAllAlive(ServiceFactoryPrxHelper.java:1620)^M
        at ome.formats.OMEROMetadataStoreClient.ping(OMEROMetadataStoreClient.java:576)^M
        ... 10 more^M
2010-09-12 12:06:36,899 705187     [4-thread-1] DEBUG      ome.formats.OMEROMetadataStoreClient  - closing client session.
2010-09-12 12:06:36,909 705197     [4-thread-1] DEBUG      ome.formats.OMEROMetadataStoreClient  - client closed.
2010-09-12 12:06:36,909 705197     [4-thread-1] DEBUG      ome.formats.OMEROMetadataStoreClient  - Logout called, shutting keep alive down.
2010-09-12 12:06:36,914 705202     [4-thread-1] DEBUG      ome.formats.OMEROMetadataStoreClient  - keepalive shut down.
2010-09-12 12:06:36,921 705209     [4-thread-1] WARN       ome.formats.importer.gui.GuiImporter  - Exception on ScreenLogin.registerGroup()
Ice.CommunicatorDestroyedException^M
        at IceInternal.Instance.objectAdapterFactory(Instance.java:122)^M
        at Ice.ObjectPrxHelperBase.createDelegate(ObjectPrxHelperBase.java:997)^M
        at Ice.ObjectPrxHelperBase.__getDelegate(ObjectPrxHelperBase.java:946)^M
        at omero.api.IAdminPrxHelper.getEventContext(IAdminPrxHelper.java:1348)^M
        at omero.api.IAdminPrxHelper.getEventContext(IAdminPrxHelper.java:1322)^M
        at ome.formats.OMEROMetadataStoreClient.getUserGroups(OMEROMetadataStoreClient.java:1678)^M
        at ome.formats.OMEROMetadataStoreClient.mapUserGroups(OMEROMetadataStoreClient.java:1715)^M
        at ome.formats.importer.gui.GuiImporter.logout(GuiImporter.java:721)^M
        at ome.formats.importer.gui.GuiImporter.update(GuiImporter.java:744)^M
        at ome.formats.importer.util.ClientKeepAlive.notifyObservers(ClientKeepAlive.java:136)^M
        at ome.formats.importer.util.ClientKeepAlive.run(ClientKeepAlive.java:79)^M
        at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)^M
        at java.util.concurrent.FutureTask$Sync.innerRunAndReset(Unknown Source)^M
        at java.util.concurrent.FutureTask.runAndReset(Unknown Source)^M
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(Unknown Source)^M
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.runPeriodic(Unknown Source)^M
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)^M
        at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)^M
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)^M
        at java.lang.Thread.run(Unknown Source)^M

[jburel]

Brian: could you check if this is still happening?

[jburel]

This is still happening
e.g.

2011-07-01 12:05:54,073 207089     [4-thread-1] WARN       ome.formats.importer.gui.GuiImporter  - Exception on ScreenLogin.registerGroup()
Ice.CommunicatorDestroyedException
	at IceInternal.Instance.objectAdapterFactory(Instance.java:122)
	at Ice.ObjectPrxHelperBase.createDelegate(ObjectPrxHelperBase.java:997)
	at Ice.ObjectPrxHelperBase.__getDelegate(ObjectPrxHelperBase.java:946)
	at omero.api.IQueryPrxHelper.findAllByQuery(IQueryPrxHelper.java:318)
	at omero.api.IQueryPrxHelper.findAllByQuery(IQueryPrxHelper.java:292)
	at ome.formats.OMEROMetadataStoreClient.getUserGroups(OMEROMetadataStoreClient.java:1948)
	at ome.formats.OMEROMetadataStoreClient.mapUserGroups(OMEROMetadataStoreClient.java:1984)
	at ome.formats.importer.gui.GuiImporter.logout(GuiImporter.java:725)
	at ome.formats.importer.gui.GuiImporter.update(GuiImporter.java:749)
	at ome.formats.importer.util.ClientKeepAlive.notifyObservers(ClientKeepAlive.java:136)

Require:

• review the login sequence
• check the state of the session
• centralize the connection status.

Pushing, to real need to modify that code now.