Task #3650 (assigned)
Opened 13 years ago
Last modified 13 years ago
List of functions to be merged — at Version 12
| Reported by: | atarkowska | Owned by: | atarkowska |
|---|---|---|---|
| Priority: | critical | Milestone: | OMERO-Beta4.3 |
| Component: | OmeroPy | Version: | n.a. |
| Keywords: | n.a. | Cc: | jamoore |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 1.0d |
| Sprint: | 2011-01-27 (4) |
Description (last modified by wmoore)
After first look through the webclient_gateway.py, several general points:
- Every query also loads object details (creationEvent, owner, group) - can this be done by omero.gateway?
- Main overlap between methods is in the list, get, lookup object - see #3658
- def listSelectedProjects(self, ids)
- def lookupProjects (self, eid=None, page=None)
- def listProjects(self, only_owned=False)
- DatasetWrapper?.getChildren vv def lookupImagesInDataset (self, oid, eid=None, page=None)
TODO: begin by identifying groups of methods of similar type and merging.
- getDatasetImageLinks etc. -> getChildLinks("Dataset", oID), getParentLinks("Image", oID), getLink("Dataset", parent_id, "Image", child_id) -- Ola
- getImagesByTag etc. -> getObjectByAnnotation("Image", AnnID) -- Ola
- getDatasetsById etc. -> getObjects("Dataset", oids). P/D/I, S/P/W etc. -- Will DONE r8905
- getTagsByIds etc -> getAnnotations(oids) -- Will
- listOrphanedDatasets etc -> listOrphans("Dataset")
- listImagesInDataset etc -> getChildren(parent_type="Dataset", oid)
- getImageAnnotationLink etc -> getAnnotation
- getImageAnnotationLink(self, parent, oid) etc -> getAnnotationLink("Image", parentID, annID). NB note change of arg names to indicate they are both IDs
Change History (12)
comment:1 Changed 13 years ago by jmoore
- Cc jmoore added
comment:2 Changed 13 years ago by wmoore
comment:3 Changed 13 years ago by wmoore
- Description modified (diff)
comment:4 Changed 13 years ago by wmoore
- Description modified (diff)
comment:5 Changed 13 years ago by atarkowska
- Description modified (diff)
comment:6 Changed 13 years ago by wmoore
- Sprint set to 2011-01-27 (4)
comment:7 Changed 13 years ago by atarkowska
- Owner set to atarkowska
- Remaining Time set to 1
- Status changed from new to assigned
comment:8 Changed 13 years ago by wmoore
- Description modified (diff)
comment:9 Changed 13 years ago by wmoore
- Description modified (diff)
Ola, I think that's most of the method types we can merge for now.
comment:10 Changed 13 years ago by wmoore
(In [8905/omero]) Merging methods such as getDatasetsById(ids) etc from webclient_gateway into a single getObjects("Dataset", ids) method and moving it into Blitz gateway. See #3650
comment:11 Changed 13 years ago by wmoore
(In [8906/omero]) Small fix to previous commit. See #3650
comment:12 Changed 13 years ago by wmoore
- Description modified (diff)
Ola - I'm going to do getTagsByIds etc.
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
(In [8738]) Added TODO comments about similar methods in omero.gateway. See #3650