Task #6897 (closed)
Opened 13 years ago
Closed 12 years ago
BUG: Comment Stream is inconsistent in Insight and Web
Reported by: | sylittlewood | Owned by: | atarkowska |
---|---|---|---|
Priority: | minor | Milestone: | Unscheduled |
Component: | Web | Version: | n.a. |
Keywords: | n.a. | Cc: | jburel, atarkowska |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description
When displaying the comments associated with an image/project/dataset the comment stream is displayed in reverse order in Insight to the Web interface.
As to which one of these is correct I am unsure, but I found it slightly confusing to have this irregular behaviour between clients.
Attachments (1)
Change History (3)
Changed 13 years ago by sylittlewood
comment:1 Changed 13 years ago by jburel
Similar to the discussion we had related to the "activities" dialog, the most recent should be at the top of the list.
comment:2 Changed 12 years ago by wmoore
- Resolution set to fixed
- Status changed from new to closed
The web now orders Comments with most recent at the top since:
jrs-macbookpro-25107:OMERO will$ git show 84d90f55 commit 84d90f552e21a8660ea00e23ee53ae7aaf1f733b Author: Will Moore <will@lifesci.dundee.ac.uk> Date: Mon Oct 10 13:22:38 2011 +0100 Fix comments ordering in web: latest comment at top. diff --git a/components/tools/OmeroWeb/omeroweb/webclient/controller/container.py b/components/tools/OmeroWeb/omeroweb/webclient/controller/container.py index cb70041..559b811 100755 --- a/components/tools/OmeroWeb/omeroweb/webclient/controller/container.py +++ b/components/tools/OmeroWeb/omeroweb/webclient/controller/container.py @@ -424,7 +424,7 @@ class BaseContainer(BaseController): else: annTypes[annClass].append(ann) - self.text_annotations.sort(key=lambda x: x.creationEventDate()) + self.text_annotations.sort(key=lambda x: x.creationEventDate(), reverse=True) self.file_annotations.sort(key=lambda x: x.creationEventDate()) self.rating_annotations.sort(key=lambda x: x.creationEventDate()) self.tag_annotations.sort(key=lambda x: x.textValue)
screenshot showing inconsistent comment stream