BUG: 404 shouldn't give QA form

[omero-qa]

​http://qa.openmicroscopy.org.uk/qa/feedback/4318/

Comment: Left the Web UI idle for a few minutes - went back - clicked on "orphaned images" - no images in there (had deleted one earlier) - clicked on image in "new dataset" intending to copy and then delete again to see what happened - had this crash. No cause obvious from my side. Gus Win 7 IE 9 as gus on howe

On refreshing the window after error the images are no longer visible, might have been deleted or moved to another dataset.

Traceback (most recent call last):

  File "/home/hudson/hudson/workspace/OMERO-merge-blue/src/dist/lib/python/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/home/hudson/hudson/workspace/OMERO-merge-blue/src/dist/lib/python/omeroweb/decorators.py", line 313, in wrapped
    retval = f(request, *args, **kwargs)

  File "/home/hudson/hudson/workspace/OMERO-merge-blue/src/dist/lib/python/omeroweb/decorators.py", line 347, in wrapper
    context = f(request, *args, **kwargs)

  File "/home/hudson/hudson/workspace/OMERO-merge-blue/src/dist/lib/python/omeroweb/webclient/views.py", line 710, in load_metadata_details
    manager = BaseContainer(conn, index=index, **{str(c_type): long(c_id)})

  File "/home/hudson/hudson/workspace/OMERO-merge-blue/src/dist/lib/python/omeroweb/webclient/controller/container.py", line 97, in __init__
    raise AttributeError("We are sorry, but that image (id:%s) does not exist, or if it does, you have no permission to see it.  Contact the user you think might share that data with you." % str(image))

AttributeError: We are sorry, but that image (id:92) does not exist, or if it does, you have no permission to see it.  Contact the user you think might share that data with you.


<WSGIRequest
GET:<QueryDict: {}>,
POST:<QueryDict: {}>,
COOKIES:{'sessionid': 'bb2aa09369611966c31d55e298faa834'},
META:{'DOCUMENT_ROOT': '/var/www',
 'GATEWAY_INTERFACE': 'CGI/1.1',
 'HTTP_ACCEPT': 'text/html, */*; q=0.01',
 'HTTP_ACCEPT_ENCODING': 'gzip, deflate',
 'HTTP_ACCEPT_LANGUAGE': 'en-gb',
 'HTTP_CONNECTION': 'Keep-Alive',
 'HTTP_COOKIE': 'sessionid=bb2aa09369611966c31d55e298faa834',
 'HTTP_HOST': 'howe.openmicroscopy.org.uk',
 'HTTP_REFERER': 'http://howe.openmicroscopy.org.uk/webclient/',
 'HTTP_UA_CPU': 'AMD64',
 'HTTP_USER_AGENT': 'Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Win64; x64; Trident/5.0)',
 'HTTP_X_REQUESTED_WITH': 'XMLHttpRequest',
 'PATH': '/usr/local/bin:/usr/bin:/bin',
 'PATH_INFO': u'/webclient/metadata_details/image/92/',
 'PATH_TRANSLATED': '/var/www/omero.fcgi/webclient/metadata_details/image/92/',
 'QUERY_STRING': '',
 'REMOTE_ADDR': '10.34.2.150',
 'REMOTE_PORT': '52059',
 'REQUEST_METHOD': 'GET',
 'REQUEST_URI': '/webclient/metadata_details/image/92/',
 'SCRIPT_FILENAME': '/var/www/omero.fcgi',
 'SCRIPT_NAME': u'',
 'SERVER_ADDR': '134.36.65.228',
 'SERVER_ADMIN': 'webmaster@localhost',
 'SERVER_NAME': 'howe.openmicroscopy.org.uk',
 'SERVER_PORT': '80',
 'SERVER_PROTOCOL': 'HTTP/1.1',
 'SERVER_SIGNATURE': '<address>Apache/2.2.14 (Ubuntu) Server at howe.openmicroscopy.org.uk Port 80</address>\n',
 'SERVER_SOFTWARE': 'Apache/2.2.14 (Ubuntu)',
 'wsgi.errors': <flup.server.fcgi_base.TeeOutputStream object at 0x2ec3c10>,
 'wsgi.input': <flup.server.fcgi_base.InputStream object at 0x2ec37d0>,
 'wsgi.multiprocess': True,
 'wsgi.multithread': False,
 'wsgi.run_once': False,
 'wsgi.url_scheme': 'http',
 'wsgi.version': (1, 0)}>

[wmoore]

Also reported in #9258.

[jmoore]

This shouldn't pop-up a QA/feedback form with "internal server error". It's fine to say, "error: object doesn't exist" or whatever. But we (the OME team) don't need to hear about it.

[wmoore]

After several commits, ending with ​https://github.com/aleksandra-tarkowska/openmicroscopy/commit/d86f992cc254725d684d4b01762e0bfcb81d4096
This is now fixed:

We use the handlerInternalError() method in feedback.views to return 404 for when Container has Object Not Found. This was already been done in a number of places. This works with debug = True, unlike raise Http404.

* d86f992 Adding logger.warning() to handlerInternalError(). See #8832
* d51b2da Remove logger.error() for ObjectNotFound in views.py. See #8832
* 3cad13c Remove OmeroObjectNotFound, use AttributeError. See #8832
* f29a602 Fix issue when no stats available (see #9124)
* b98c421 Object-Not-Found returns 404 for Ajax dialog. See #8832
* f71e8de Refactor container.py None checks into single method. See #8832

[jmoore]

Looks good, Will.

[saloynton]

Reproduced steps and no error message was seen.