Bug: build fails when dist.dir is set

[sbesson]

When building 4.4.0-RC1 with -Ddist.dir set, the build fails with

/private/tmp/homebrew-omero-4.4.0-RC1-C1SF/components/insight/build/dist.xml:57: ERROR: dist.dir is currently set!

        This most likely occurred because dist.dir was set on the top-level
        build:  ./build.py -Ddist.dir=/tmp/example

        This no longer works with the insight build. Instead, set dist.dir
        in the etc/local.properties file.

This is currently blocking the upgrade of the OMERO homebrew installation for 4.4 since -Ddist.dir must be set to the homebrew prefix.

[jmoore]

Sebastien, as the message says, just set dist.dir=... inside of etc/local.properties rather than passing it on the command line. i.e.:

echo dir.dir=...
./build.py

rather than

./build.py -Ddist.dir=...

The only way to remove this restriction will be to rename the "dist.dir" property in the insight build, since once a property is set in ant, it can't be modified.

[sbesson]

Josh, just tried this. However, homebrew doesn't let you write to folders other than prefix, i.e. I can not create a local.properties file under /Library/Caches/Homebrew?/omero--git

I see two ways to fix this:

• either, we need to adapt the insight build
• or we could add another property, e.g. config.dir, that would be set to ${root.dir}/etc by default in global.xml. Then, I would simply use

./build.py -Dconfig.dir=...

Do you think this makes sense?

[sbesson]

Actually I just opened a PR that implements the suggestion above ​https://github.com/openmicroscopy/openmicroscopy/pull/211

[sbesson]

Fixed homebrew 4.4 installation by setting dist.dir in /etc/local.properties
​https://github.com/openmicroscopy/homebrew-alt/pull/4