Task #10095 (closed)
Opened 11 years ago
Closed 11 years ago
Improvements to windows service user
Reported by: | spli | Owned by: | bpindelski |
---|---|---|---|
Priority: | minor | Milestone: | OMERO-4.4.7 |
Component: | Deployment | Version: | n.a. |
Keywords: | n.a. | Cc: | jamoore |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | 2013-02-12 (5) |
Description (last modified by bpindelski)
A couple of issues found in PR539:
- OMERO.master Windows service is not removed after a failed startup, for instance if an incorrect user/password are given.
- There are two ways to specify the user (config file and with the admin start -u option) but the password is always read from the config file. A warning and/or the ability to provide the password at the command line would be helpful.
Added by bpindelski:
After discussing with jmoore, it seems feasible to also drop the support for sc.exe and use pure Win32 API calls. This requires PyWin32 to be installed, but we already state that as a requirement in the docs. Added value: no string comparisons anymore to check service status.
- Remove the dependency on sc.exe from admin.py
- Update the Windows docs for develop and dev_4_4 (listings of bin\omero admin ... output and make PyWin32 stand out as a requirement)
Change History (14)
comment:1 Changed 11 years ago by bpindelski
- Cc jmoore added
comment:2 Changed 11 years ago by bpindelski
comment:3 Changed 11 years ago by jmoore
Blazej, I wouldn't have any objection to removing sc.exe if it's straight-forward enough. What's the reasoning?
comment:4 Changed 11 years ago by bpindelski
Removing sc.exe means using Win32 API methods from the Python bindings. It's more a nice-to-have than a bugfix and is justified by the fact I already am working on admin.py. It also would give us more control over the service status message output (now we are doing string comparisons to see if the start-up/shutdown succeeded etc.).
comment:5 Changed 11 years ago by jmoore
We have had bugs due to the string comparisons (Spanish-speaking user on the forums). So again, if it's straight-forward, go for it. Otherwise, let's hold off.
comment:6 Changed 11 years ago by bpindelski
Understood. Seems that the Win32 API has all the methods needed to create, delete, start and stop services.
comment:7 Changed 11 years ago by bpindelski
- Description modified (diff)
comment:8 Changed 11 years ago by bpindelski
- Milestone changed from Unscheduled to OMERO-4.5
- Sprint set to 2013-01-15 (4)
comment:9 Changed 11 years ago by bpindelski
- Description modified (diff)
comment:10 Changed 11 years ago by bpindelski
- Status changed from new to accepted
comment:11 Changed 11 years ago by jburel
- Sprint changed from 2013-01-15 (4) to 2013-02-12 (5)
Moved from sprint 2013-01-15 (4)
comment:12 Changed 11 years ago by Blazej Pindelski <bpindelski@…>
(In [8ce4fde678dbb16379e6cae5237e8611e34e738c/ome.git] on branch develop) Update admin.py on Windows (see #10095)
- Remove (almost) all instances of sc.exe
- Update messages displayed to user when managing Windows service
- Catch return value from ServiceStart? (remove string comparisons)
comment:13 Changed 11 years ago by Josh Moore <josh@…>
(In [559b5a629a36882169210e1fd23a8257b51da02e/ome.git] on branch develop) Merge pull request #609 from bpindelski/rebased/develop/10095_admin_sc
Improvements to windows service user (see #10095) (rebased onto develop)
comment:14 Changed 11 years ago by bpindelski
- Resolution set to fixed
- Status changed from accepted to closed
Josh, would it make sense with this chunk of work to also drop the dependency on sc.exe and use pure win32* Python methods?