Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #10251 (closed)

Opened 11 years ago

Closed 11 years ago

Bug: Non-standard character encodings in source files

Reported by: spli Owned by: spli
Priority: major Milestone: OMERO-4.4.7
Component: General Version: n.a.
Keywords: n.a. Cc: jburel, jamoore
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2013-02-12 (5)

Description (last modified by spli)

components/blitz/test/ome/services/blitz/test/utests/ManagedRepositoryITest.java in the develop branch contains non-ASCII characters, which aren't encoded in UTF-8, and it's unclear what the correct character encoding should be

See line 405
https://github.com/openmicroscopy/openmicroscopy/blob/a4e2c07c6b69cef407239ce87bc6520141ec03e0/components/blitz/test/ome/services/blitz/test/utests/ManagedRepositoryITest.java#L405

Or look at the raw Github file and change the browser encoding to whatever:
https://raw.github.com/openmicroscopy/openmicroscopy/a4e2c07c6b69cef407239ce87bc6520141ec03e0/components/blitz/test/ome/services/blitz/test/utests/ManagedRepositoryITest.java

Apparently this should be String expected = "%björk%". Depending on operating system/environment/Java settings this may fail to compile (the test-compile target fails for me, but works for mtbcarroll).

We should either pick a single encoding (UTF-8?) or stick to plain ASCII and use \uXXXX escapes.

test-compile:
Copying 6 files to /Users/simon/work/openmicroscopy.dev/components/blitz/target/test-classes
Compiling 112 source files to /Users/simon/work/openmicroscopy.dev/components/blitz/target/test-classes
/Users/simon/work/openmicroscopy.dev/components/blitz/test/ome/services/blitz/test/utests/ManagedRepositoryITest.java:405: error: unmappable character for encoding UTF8
        String expected = "%bj?rk%";
                              ^
/Users/simon/work/openmicroscopy.dev/components/blitz/test/ome/services/blitz/test/utests/ManagedRepositoryITest.java:407: error: unmappable character for encoding UTF8
        String actual = this.tmri.expandTemplate("%bj?rk%", curr);
                                                     ^
2 errors
 
BUILD FAILED
/Users/simon/work/openmicroscopy.dev/build.xml:315: The following error occurred while executing this line:
/Users/simon/work/openmicroscopy.dev/build.xml:309: The following error occurred while executing this line:
/Users/simon/work/openmicroscopy.dev/components/antlib/resources/global.xml:361: The following error occurred while executing this line:
/Users/simon/work/openmicroscopy.dev/components/antlib/resources/lifecycle.xml:213: Compile failed; see the compiler error output for details.

Change History (3)

comment:1 Changed 11 years ago by spli

  • Description modified (diff)

comment:2 Changed 11 years ago by spli

  • Milestone changed from Unscheduled to OMERO-4.5
  • Owner set to spli
  • Remaining Time set to 0.1
  • Sprint set to 2013-02-12 (5)
  • Status changed from new to accepted

comment:3 Changed 11 years ago by spli

  • Remaining Time changed from 0.1 to 0
  • Resolution set to fixed
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.68402 sec.)

We're Hiring!