Task #10778 (closed)
Evaluate MIF highlighting in insight
| Reported by: | jamoore | Owned by: | bpindelski |
|---|---|---|---|
| Priority: | critical | Milestone: | 5.0.0-beta1 |
| Component: | Insight | Version: | n.a. |
| Keywords: | fs | Cc: | fs@…, ux@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | FS demo 4.1 |
Description
As discussed with Will Moore after demo 3, it would be nice to add a touch of highlighting to multiple-image filesets (MIFs) which a user has selected them. This may only be activated when an action like chgrp or delete is being used, but first it must be estimated how long it would take to add such highlighting to insight.
Attachments (1)
Change History (13)
Changed 11 years ago by jamoore
comment:1 Changed 11 years ago by jamoore
comment:2 Changed 11 years ago by bpindelski
- Status changed from new to accepted
comment:3 Changed 11 years ago by bpindelski
After some debugging and trying to grok the code, it seems that BrowserComponent.setSelectedDisplays(TreeImageDisplay[], boolean) will give me access to the currently selected node(-s) in the tree viewer. I can extract the fileset ID from the node. The question now is - do I need a fileset-to-image loader in the treeviewer package? Would I need to fire an event to get other images in the same fileset and then have a method that changes the background of the other nodes that constitute the fileset? Investigation needed.
comment:4 Changed 11 years ago by jburel
Blazej: I was thinking of re-using/re-writing the multi-image object to display the MIF since the code is already in place from previous FS work with Colin.
So you will have to modify methods in org.openmicroscopy.shoola.agents.treemng.TreeViewerTranslator to generate multi-images data object (that pojo will have to be modified) That approach will bring us closer to the user's expectation. The flat view with highlight is okay but far from general use case.
comment:5 Changed 11 years ago by bpindelski
Jean-Marie: I do agree with universal solutions, but taking the time-constraint of Demo 4, what would be the simplest (and not too hacky) solution to solve the problem mentioned in the ticket?
comment:6 Changed 11 years ago by bpindelski
The current status of MIF highlighting is at https://github.com/bpindelski/openmicroscopy/commits/insight-mif. A rudimentary solution is in place, but needs some more work.
comment:7 Changed 11 years ago by bpindelski
After another round of code review, I think a better place for the MIF logic would be the org.openmicroscopy.shoola.agents.util.browser.NodeSelectionVisitor. It is used by both the browser and treeviewer agents. The logic inside the visitor would need to be modified in a way that multi-selection and single-node-MIF selection could co-exist. The POJO mentioned by Jean-Marie (MultiImageData) is not used anywhere at the moment, so it would take me longer to deduct how to plug it in in the existing code structure.
comment:8 Changed 11 years ago by jburel
table view: highlight is in place in web
comment:9 Changed 11 years ago by bpindelski
The final task left here is implementing highlighting in the list (table) view. Web and Insight already do the same when filtering highlighted results (e.g. by name). The highlighting in that case is removed.
comment:10 Changed 11 years ago by bpindelski
https://github.com/bpindelski/openmicroscopy/commits/mif-highlight has list (table) view almost done, some minor fixes needed.
comment:11 Changed 11 years ago by bpindelski
- Resolution set to fixed
- Status changed from accepted to closed
Implemented in https://github.com/openmicroscopy/openmicroscopy/pull/1169
comment:12 Changed 11 years ago by Josh Moore <josh@…>
(In [a47369eb1eb243ad774313255030a36a8f49726c/ome.git] on branch develop) Merge pull request #1169 from bpindelski/mif-highlight
Add MIF highlighting in Insight (see #10778)
marked up screencapture of MIFs in web