Task #11149 (closed)
Opened 11 years ago
Closed 9 years ago
RFE: Allow non-SSL CLI import.
Reported by: | jamoore | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | 5.1.1 |
Component: | OmeroFs | Version: | 5.0.1 |
Keywords: | n.a. | Cc: | fs@…, sbesson |
Resources: | n.a. | Referenced By: | https://trello.com/c/EOL8YL14/54-bug-import |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description
There's currently no flag for the CLI or for import in particular to drop out of SSL like the checkbox in the clients.
This could likely be backported to dev_4_4, and would generally speed-up import for DropBox?, et al.
Change History (5)
comment:1 Changed 10 years ago by jamoore
- Milestone changed from 5.x to 5.0.3
- Version set to 5.0.1
comment:2 Changed 10 years ago by jamoore
comment:3 Changed 10 years ago by jburel
- Referenced By set to https://trello.com/c/EOL8YL14/54-bug-import
comment:4 Changed 9 years ago by jamoore
- Milestone changed from 5.1.0-m4 to 5.1.1
- Owner jamoore deleted
I've looked into this (lightly) a few times, and never been able to convince myself of the state of things. Probably needs a detailed reading and a quick final decision. I don't suspect the solution (if needed) will be hard.
comment:5 Changed 9 years ago by jamoore
- Resolution set to invalid
- Status changed from new to closed
I get:
2015-04-20 15:39:04,846 53909 [ main] WARN ts.importer.transfers.UploadFileTransfer - b620117a-e4b7-4d78-94e1-a93d1b126177/779c3789-ea2c-44c2-ba87-0e495a243f06-RepoRawFileStoreI -t -e 1.0:tcp -h 192.168.178.23 -p 58134:tcp -h 192.168.59.3 -p 58134:tcp -h 192.168.178.96 -p 58134
from
+++ b/components/blitz/src/ome/formats/importer/transfers/UploadFileTransfer.java @@ -47,7 +47,7 @@ public class UploadFileTransfer extends AbstractFileTransfer { final File file = state.getFile(); final byte[] buf = state.getBuffer(); final ChecksumProvider cp = state.getChecksumProvider(); - + FileInputStream stream = null; try { @@ -56,12 +56,13 @@ public class UploadFileTransfer extends AbstractFileTransfer { long offset = 0; state.uploadStarted(); - + // "touch" the file otherwise zero-length files + log.warn(rawFileStore.toString());
i.e. the connection is tcp and not ssl. In other words, this is already the case. Closing.
This requires mostly stepping through the code to make sure that all code paths end up with a non-SSL connection for transferring binary to the server. If it's *not* currently happening, it would be better to make that the default, and then subsequently add an option to turn it off.