Task #12513 (closed)
Bug: Import log sizes are inaccurate
Reported by: | mtbcarroll | Owned by: | mtbcarroll |
---|---|---|---|
Priority: | major | Milestone: | 5.1.0-m4 |
Component: | Import | Version: | 5.0.3 |
Keywords: | n.a. | Cc: | cblackburn, bpindelski |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | 0.0d |
Sprint: | n.a. |
Description
The OriginalFile.size recorded for import logs is inaccurate: it underestimates, stopping at the size after Step 4 is recorded, rather like #12152.
Change History (8)
comment:1 Changed 10 years ago by jamoore
- Milestone changed from Unscheduled to 5.1.0
- Owner jamoore deleted
- Priority changed from minor to major
comment:2 Changed 10 years ago by mtbcarroll
They don't have a hasher set at all.
comment:3 Changed 10 years ago by jamoore
Aha. Then if there's no easy place to do the touch(), they would be a candidate for detecting the null hasher and updating size/hash in the background.
comment:4 Changed 9 years ago by jamoore
- Cc changed from cblackburn,bpindelski to cblackburn, bpindelski
- Owner set to mtbcarroll
Mark: have my recent PRs improved this?
comment:5 Changed 9 years ago by mtbcarroll
Not to my knowledge.
comment:6 Changed 9 years ago by mtbcarroll
- Resolution set to fixed
- Status changed from new to closed
comment:7 Changed 9 years ago by mtbcarroll
- Milestone changed from 5.1.0 to 5.1.0-m4
comment:8 Changed 9 years ago by Josh Moore <josh@…>
- Remaining Time set to 0
(In [31f73a28575d2281aca14d7ab1b8f2420fc4227f/ome.git] on branch develop) Merge pull request #3458 from mtbc/fix-12513-import-log-size
fix #12513: close import log earlier to set its size correctly
Is the hash also incorrect? In which case, this likely needs to be prioritized a bit more. Optimal would be a simple location in the process where a touch() on the RawFileStore (or RepositoryDao?) could be performed which would bump the values.