Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #2067 (closed)

Opened 14 years ago

Closed 9 years ago

Remove "broken" flag from passing tests

Reported by: jamoore Owned by: wmoore
Priority: minor Milestone: Unscheduled
Component: General Version: 5.1.0
Keywords: n.a. Cc: jburel
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: n.a.

Description (last modified by jmoore)

Tests which have been marked "broken" should be reviewed and fixed or removed(but possibly later) First priority is to get everything green.

Change History (69)

comment:1 Changed 14 years ago by cxallan

  • Sprint changed from 2010-03-19 (5) to 2010-04-02 (6)

comment:2 Changed 14 years ago by cxallan

  • Sprint changed from 2010-04-02 (6) to 2010-04-16 (7)

comment:3 Changed 14 years ago by cxallan

  • Sprint changed from 2010-04-16 (7) to 2010-04-30 (8)

comment:4 Changed 14 years ago by jmoore

  • Sprint changed from 2010-04-30 (8) to 2010-05-13 (9)

comment:5 Changed 14 years ago by cxallan

  • Sprint changed from 2010-05-13 (9) to 2010-05-27 (10)

comment:6 Changed 14 years ago by cxallan

  • Sprint changed from 2010-05-27 (10) to 2010-06-10 (11)

comment:7 Changed 14 years ago by jburel

  • Cc jburel added
  • Milestone changed from OMERO-Beta4.2 to Unscheduled
  • Sprint 2010-06-10 (11) deleted

comment:8 Changed 14 years ago by cxallan

  • Owner set to cxallan
  • Status changed from new to assigned

comment:9 Changed 14 years ago by cblackburn

(In [7638]) Fixes ome.system.utests.ContextTest?.test_uniqueNonStaticContext See #2067

comment:10 Changed 14 years ago by cblackburn

(In [7638]) Disbaled testBadUrl1() which fails on Hudson but passes on local build. Other bad url test seem to pass on Hudson. Corrected typos in method names."

comment:11 Changed 14 years ago by bwzloranger

Fixed in r7640 (Beta4.2) and r2641 (Trunk)

comment:12 Changed 14 years ago by cxallan

(In [7643]) Fix for tinyTest.d3d.dv classpath when running unit tests across all components. (See #2067)

comment:13 Changed 14 years ago by cxallan

(In [7647]) Adding temporary directory capabilities to the ROMIO tests and removing all references to JUnit. (See #2067)

comment:14 Changed 14 years ago by cxallan

(In [7649]) Move the entire metadata validator to the "manual" group. (See #2067)

comment:15 Changed 14 years ago by cxallan

(In [7651]) Stopping ome.dsl.* unit tests from being run under the common component causing CLASSPATH resolution issues for those tests. (See #2067)

comment:16 Changed 14 years ago by cxallan

(In [7653]) Cleanup importer component unit test package dependencies (explicitly use ome.formats.* and ome.services.*) and fix up TestReader? and TestReader? usage. (See #2067)

comment:17 Changed 14 years ago by cxallan

(In [7656]) Fixing ImporterConfigTest?.testDefaultGetsLoaded(). (See #2067)

comment:18 Changed 14 years ago by cblackburn

(In [7657]) Permissions.grant() is currently unimplemented and so testImmutableSerialization() fixed to handle that for now. See #2067 (and #375).

comment:19 Changed 14 years ago by cxallan

(In [7658]) Adding "manual" to the list of OmeroImporter component excluded test groups and made the BasicImporterClientTest? manual due to its dependency on omero.host, omero.user, omero.pass, etc. (See #2067)

comment:20 Changed 14 years ago by cxallan

(In [7659]) Fixing counts being checked for unloaded exceptions and disabling the null value in ordered collection test to be reviewed later. (See #2067)

comment:21 Changed 14 years ago by cxallan

(In [7660]) Fixing component specific TestNG package descriptions to avoid tests from other components being run in the suite. (See #2067)

comment:22 Changed 14 years ago by atarkowska

(In [7663]) test.integration.client_ctors fixed, see #2067

comment:23 Changed 14 years ago by cxallan

(In [7666]) Attempting to move minidom Document import to the package scope. (See #2067)

comment:24 Changed 14 years ago by atarkowska

(In [7670]) test.integration fixes, see #2067

comment:25 Changed 14 years ago by atarkowska

(In [7673]) test.integration fixes, see #2067

comment:26 Changed 14 years ago by atarkowska

(In [7678]) this fixes #2542 and test.integration fixes, see #2067

comment:27 Changed 14 years ago by jburel

r7688, fixed some broken tests related to the creation of clients.

comment:28 Changed 14 years ago by jburel

r7690, fixed broken related to metadata

comment:29 Changed 14 years ago by cxallan

(In [7696]) Completed overhaul of the search C++ tests. (See #2067)

comment:30 Changed 14 years ago by cblackburn

(In [7698]) Change to logging and report levels for cpp integration tests. See #2067

comment:31 Changed 14 years ago by cxallan

(In [7703]) Removing fail on error from C++ integration test exec. (See #2067)

comment:32 Changed 14 years ago by cxallan

(In [7707]) Trying STDERR going to boost-integration.xml and STDOUT going to boost-integration.err. (See #2067)

comment:33 Changed 14 years ago by cblackburn

(In [7709]) Switching back to putting log output in .xml file to check xUnit. (See #2067)

comment:34 Changed 14 years ago by cblackburn

(In [7710]) Removing std output from api.cpp as this breaks the xml schema for xUnit. (See #2067)

comment:35 Changed 14 years ago by cblackburn

(In [7715]) 3 hard fails commented out. (See #2067)

comment:36 Changed 14 years ago by cblackburn

(In [7719]) test989 removed. tests 880, 883Upload and 985 forced to pass. duplicate 880 commented. Tests need reviewing. (See #2067)

comment:37 Changed 14 years ago by cblackburn

(In [7729]) test880 fails to create its fixture on Hudson. Can't reproduce locally so catching for now. createTestImage needs to be fixed. (See #2067)

comment:38 Changed 14 years ago by cblackburn

(In [7731]) Two more occurences of createTestImage failing (see r7730) Can't reproduce locally so catching for now. createTestImage needs to be fixed. (See #2067)

comment:39 Changed 14 years ago by jburel

  • Milestone changed from Unscheduled to Work in Progress
  • Sprint set to 2010-08-12 (14)

comment:40 Changed 14 years ago by jburel

  • Milestone changed from Work in Progress to OMERO-Beta4.2.1
  • Sprint 2010-08-12 (14) deleted

comment:41 Changed 14 years ago by jburel

  • Milestone changed from OMERO-Beta4.2.1 to Work in Progress
  • Sprint set to 2010-08-12 (14)

comment:42 Changed 14 years ago by cblackburn

(In [7732]) Two tests against guest user commented out. Rexamine after making a decision on the need for a guest user. (See #2067)

comment:43 Changed 14 years ago by jburel

  • Milestone changed from Work in Progress to OMERO-Beta4.2.1

comment:44 Changed 14 years ago by cblackburn

(In [7735]) Fixed processor availability but this has probably revealed underlying errors. (See #2067)

comment:45 Changed 14 years ago by cblackburn

(In [7738]) The test now runs to completion but fails due to a key error rather than for what the assertion is testing. This test should be reviewed. (See #2067)

comment:46 Changed 14 years ago by cblackburn

(In [7739]) The test now runs to completion. It now fails because the parameter types are wrong. I am leaving this one to fail. (See #2067)

comment:47 Changed 14 years ago by cblackburn

(In [7740]) Test completes locally. The paths in the import_image() helper method may be fragile, this method could be more robust. (See #2067)

comment:48 Changed 14 years ago by wmoore

(In [7748]) Adding Python integration tests see #2067, one of which fails: See #2658.

comment:49 Changed 14 years ago by jmoore

(In [7752]) Fixing ping.py (See #2067) including no more EndpointParseExceptions (Fix #2659)

comment:50 Changed 14 years ago by cblackburn

(In [7765]) Removing old and now unnecessary projection test. (See #2067)

comment:51 Changed 14 years ago by cxallan

(In [7784]) Without specifying a data type 'int64' can be used (and is with a newer numpy on a 64-bit platform). Forcing the data type to 'uint8'. (See #2067)

comment:52 Changed 14 years ago by cxallan

(In [7786]) Make sure that a port argument is passed on all import attempts during integration testing. (See #2067)

comment:53 Changed 14 years ago by jburel

(In [7787]) Fixed broken test related to version (See #2067)

comment:54 Changed 14 years ago by cxallan

(In [7788]) More verbose failure message for performance related test "test1184". (See #2067)

comment:55 Changed 14 years ago by cxallan

(In [7790]) Fixing the verbosity of the failure message for "test1184". (See #2067)

comment:56 Changed 14 years ago by cxallan

(In [7793]) Fix typo in root_login_args. (See #2067)

comment:57 Changed 14 years ago by cxallan

(In [7795]) Removing usage of the gateway in an attempt to fix lingering stateful services in "integration.thumbnailPerms.TestThumbnailPerms?". (See #2067)

comment:58 Changed 14 years ago by jburel

  • Sprint changed from 2010-08-12 (14) to 2010-08-26 (15)

comment:59 Changed 14 years ago by jburel

  • Sprint changed from 2010-08-26 (15) to 2010-09-09 (16)

comment:60 Changed 14 years ago by wmoore

r8051 testSpeedOfThumbnailFigure

comment:61 Changed 14 years ago by jburel

  • Owner changed from cxallan to wmoore
  • Status changed from assigned to new

comment:62 Changed 14 years ago by jburel

  • Status changed from new to assigned

comment:63 Changed 14 years ago by wmoore

  • Remaining Time changed from 1 to 0
  • Resolution set to duplicate
  • Status changed from assigned to closed

Not sure how this is different from #2066. Closing for now

comment:64 Changed 14 years ago by jmoore

  • Description modified (diff)
  • Milestone changed from OMERO-Beta4.2.1 to Unscheduled
  • Resolution duplicate deleted
  • Sprint 2010-09-09 (16) deleted
  • Status changed from closed to reopened
  • Summary changed from Review "broken" tests to Remove "broken" flag from passing tests

Changing the name/description of this ticket, since several people have wondered about the same thing.

comment:65 Changed 13 years ago by cxallan

Referencing ticket #1736 has changed sprint.

comment:66 Changed 13 years ago by jmoore <josh@…>

(In [3c54914df517ce919a4d54864e2e9b32c291d064/ome.git] on branch dev_4_1_custom) Correcting hdfstorage locking, test commented out in r7715 (See #2067, Fix #2713)

git-svn-id: ​file:///home/svn/omero/trunk@7812 05709c45-44f0-0310-885b-81a1db45b4a6

comment:67 Changed 13 years ago by jmoore <josh@…>

(In [54d7c574cce69779b308a392c946c94a9d2f8abc/ome.git] on branch develop) Fix 'compile' error in HdfList (See #2067, #2713)

comment:68 Changed 12 years ago by jmoore

Referencing ticket #1736 has changed sprint.

comment:69 Changed 9 years ago by cblackburn

  • Component set to General
  • Priority set to minor
  • Resolution set to fixed
  • Status changed from reopened to closed
  • Version set to 5.1.0

Tests that were passing or intermittent have had the broken flag removed. Existing failing tests and work towards fixing/removing them is captured on ​https://trello.com/c/KluUDJDK/328-keep-failing-tests-on-radar

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.92855 sec.)

© 2000-2014 University of Dundee & Open Microscopy Environment. Creative Commons Attribution 3.0 Unported License
OME source code is available under the GNU General public license or through commercial license from Glencoe Software

We're Hiring!