Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #2689 (closed)

Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

`bin/omero` commands should not rely on "psql"

Reported by: jamoore Owned by: jamoore
Priority: minor Milestone: OMERO-Beta4.3
Component: General Version: n.a.
Keywords: n.a. Cc:
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2011-02-10 (5)

Description

The bin/omero db script command always load sql/psql/* to create its script. Similarly, bin/omero admin diagnostics looks for psql, which may be fine as long as it also looks for other utilities.

components/tools/OmeroPy/src/omero/plugins/admin.py:        version(["psql",         "--version"])
components/tools/OmeroPy/src/omero/plugins/db.py:        sql_directory = self.ctx.dir / "sql" / "psql" / ("%s__%s" % (db_vers, db_patch))
components/tools/OmeroPy/src/omero/plugins/db.py:        sql_directory = self.ctx.dir / "sql" / "psql" / ("%s__%s" % (db_vers, db_patch))
components/tools/OmeroPy/src/omero/plugins/db.py:--     psql omero < %s

Change History (10)

comment:1 Changed 14 years ago by jmoore

  • Remaining Time set to 1.0

comment:2 Changed 14 years ago by jmoore

Referencing ticket #2688 has changed sprint.

comment:3 Changed 14 years ago by jmoore

  • Milestone changed from Unscheduled to OMERO-Beta4.3

comment:4 Changed 13 years ago by jmoore

  • Sprint set to 2011-02-10 (5)
  • Status changed from new to accepted

comment:5 Changed 13 years ago by jmoore

  • Remaining Time changed from 1.0 to 0.25

Made significant progress on this today. It was necessary to create:

  • ${omero.db.profile}-header.vm
  • ${omero.db.profile}-footer.vm

templates to cleanly separate the different DBs.

The only somewhat unfortuante hard-coding is that we are now looking for model-*.jar to define the "omero.db.profile" from OmeroPy/src/omero/plugins/db.py, but for the moment that should be sufficient.

comment:6 Changed 13 years ago by jmoore <josh@…>

  • Remaining Time changed from 0.25 to 0
  • Resolution set to fixed
  • Status changed from accepted to closed

(In [278b163fd9033b30b00a12f2a3cd826b4fc75bd9/ome.git] on branch dev_4_1_custom) DB-specific headers as well as bin/omero db script command (Fix #2689)

comment:7 Changed 13 years ago by jmoore <josh@…>

(In [1316d349ff685bf30889a3f59eceeabae71b6ea5/ome.git] on branch dev_4_1_custom) Newly generated OMERO4.10 files (Fix #2689, See #4313)

comment:8 Changed 13 years ago by jmoore <josh@…>

(In [278b163fd9033b30b00a12f2a3cd826b4fc75bd9/ome.git]on branches 4_1_custom, dev_4_1_custom, josh/4.1-web-backport) DB-specific headers as well as bin/omero db script command (Fix #2689)

comment:9 Changed 13 years ago by jmoore <josh@…>

(In [1316d349ff685bf30889a3f59eceeabae71b6ea5/ome.git]on branches 4_1_custom, dev_4_1_custom, josh/4.1-web-backport) Newly generated OMERO4.10 files (Fix #2689, See #4313)

comment:10 Changed 13 years ago by jmoore <josh@…>

(In [b2b127d3571829aecff2987b9475c3a260bed3b2/ome.git] on branch develop) DB-specific headers as well as bin/omero db script command (Fix #2689)

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.69498 sec.)

We're Hiring!