Task #6017 (closed)
Opened 13 years ago
Closed 13 years ago
Bug: failing test testMultiProcessSession
| Reported by: | wmoore | Owned by: | cblackburn |
|---|---|---|---|
| Priority: | major | Milestone: | OMERO-Beta4.3.2 |
| Component: | OmeroPy | Version: | n.a. |
| Keywords: | n.a. | Cc: | cneves |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2011-09-15 (5) |
Description
Hi Carlos - I seem to remember creating a ticket for this before, but can't find it now.
Did you look at this earlier?
======================================================================
FAIL [15.485s]: testMultiProcessSession (gatewaytest.connection.ConnectionMethodsTest?)
Traceback (most recent call last):
File "/Users/will/Desktop/OMERO/components/tools/OmeroPy/test/gatewaytest/connection.py", line 32, in testMultiProcessSession
self.assertEqual(c2._session, None)
AssertionError?: object #0 (::omero::model::Session)
{
...
} != None
Change History (8)
comment:1 Changed 13 years ago by jmoore
- Cc cneves-x added
- Owner changed from cneves-x to jmoore
comment:2 Changed 13 years ago by jmoore
- Owner jmoore deleted
comment:3 Changed 13 years ago by atarkowska
- Sprint set to 2011-09-15 (5)
comment:4 Changed 13 years ago by atarkowska
- Owner set to atarkowska
comment:5 Changed 13 years ago by atarkowska
- Owner changed from atarkowska to cblackburn
comment:6 Changed 13 years ago by cblackburn
- Remaining Time set to 0.25
- Status changed from new to accepted
comment:7 Changed 13 years ago by Colin Blackburn <C.Blackburn@…>
(In [b520503bbfed5be732bb971fad62599110425b81/ome.git] on branch develop) Reversing the assertion logic. See #6017
comment:8 Changed 13 years ago by cblackburn
- Remaining Time changed from 0.25 to 0
- Resolution set to fixed
- Status changed from accepted to closed
This is similar to the problem in #6037. Reversing the logic of some assertions passes the tests but does it now properly test the code? In the original lines,
c2 = self.gateway.clone()
self.assert_(c2.connect(sUuid=self.gateway._sessionUuid))
self.assertEqual(c2._session, None)
a = c2.getAdminService()
can the assertEqual(c2._session, None) be correct if the call on the next line is expected to be valid?
This test should be reviewed along with that in #6037 to check that it fulfills its original purpose.
Taking away from Carlos so someone else can pick up.