Bug: matlab doesn't look for ice.config in current directory.

[jamoore]

loadOmero only finds an ice.config in the OmeroMatlab directory, not also in the current directory:

% Either first in the ICE_CONFIG environment variable
ice_config = getenv('ICE_CONFIG');
if strcmp(ice_config, '')
  % Then in the current directory.
  if exist('ice.config','file')
      ice_config = fullfile(findOmero, 'ice.config');
  end
else
    % Clearing the ice_config now, since it is available
    % in the environment, and Ice will pick it up
    % (assuming it was set before MATLAB started)
    ice_config = '';
end

Should we take care of this for 4.3.3?

[jburel]

All the matlab code should be reviewed as part of 4.4. Probably not for 4.3.3

• no copyright.
• reference to gateway, should be removed.
• query not working.
• etc.

[jmoore]

Pushing. Do we have a matlab-overhaul story we can add this to?

[jburel]

we don't have a story

[jmoore]

I've improved the handling of ice.config as well as passed in parameters, there is still one edge case that's not fixed:

If ice.config is found but the user passed in varargs without a properties, then there's no available constructor for creating the omero.client (i.e. new omero.client(Properties, *stuff)).

This is a general restriction on the loadOmero method anyway, so it might not be too onerous, but it's fairly difficult to explain. Jean-Marie: I'm going to push to my sprint6-server-backlog branch. Jean-Marie, if you could take a look, I'd appreciate it.

[jmoore]

Passing to Jean-Marie for testing.

[jburel]

Tested the latest omero tool box.

--------------------------
OmeroMatlab Toolbox 
4.3.3-ice33-90df0f21-b60
--------------------------

No problem to connect to the server.
All builds will have to be tested later on using ice34 when the framework is in place.

[jmoore]

Closing then. If there are any issues with the general lookup order ("ice.config in current directory, then in install directory, etc", feel free to speak up. Closing.

[jmoore <josh@…>]

(In [6b4b44b399a605c91f0b9e48f93dd18aa6efb0ca/ome.git] on branch develop) Improve loadOmero.m ice.config handling (See #6892)